Fix linked sound export in Animate and SWFLite paths#45
Open
Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Open
Fix linked sound export in Animate and SWFLite paths#45Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes linked sound export for the Animate export path and aligns the SWFLite path with the same linkage discovery improvements.
Previously, SWFs containing
DefineSoundassets could work in AIR while producing empty or incomplete audio exports in the Animate pipeline, because linked sound symbols were not exported as bundle assets. In addition, linkage discovery was less robust than needed for some real-world SWFs.Changes
Animate export:
DefineSoundsymbols as bundled audio assetsAnimateLibrarySWFLite export:
soundFormat -> SoundTypemappingRuntime integration:
SoundobjectsWhy
Some SWFs contain valid linked sound symbols that are not reliably recovered from the higher-level parsed structures alone. This PR makes symbol discovery more robust and ensures linked sounds are exported in a form usable by the Animate/OpenFL asset pipeline.
Scope / current limitations
This PR intentionally keeps sound container export narrow:
Validation
Validated with a real game asset, and here's a standalone repro: SWFSoundExportRepro.zip
Note
This PR requires #40.