Skip to content

feat: remove border radius & extra content #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
filippovskii09 wants to merge 6 commits into
base: release-23.x
Choose a base branch
from
Open

feat: remove border radius & extra content #4083

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4338dd
feat: remove border radius & extra contetn & add capitalize
filippovskii09 Jan 12, 2026
bab087f
fix: remove extra css property
filippovskii09 Jan 13, 2026
01f082d
fix: change hard value to default value for bd radius
filippovskii09 Jan 15, 2026
f57c2aa
Merge branch 'release-23.x' of https://github.com/openedx/paragon int…
filippovskii09 Feb 5, 2026
24df154
fix: remove search button text constant
filippovskii09 Feb 6, 2026
5a8f031
feat: add translation for search button
filippovskii09 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SearchField/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import SearchFieldSubmitButton from './SearchFieldSubmitButton';
export const SEARCH_FIELD_SCREEN_READER_TEXT_LABEL = 'search';
export const SEARCH_FIELD_SCREEN_READER_TEXT_SUBMIT_BUTTON = 'submit search';
export const SEARCH_FIELD_SCREEN_READER_TEXT_CLEAR_BUTTON = 'clear search';
export const SEARCH_FIELD_BUTTON_TEXT = 'search';
export const SEARCH_FIELD_BUTTON_TEXT = 'Search';
Copy link
Copy Markdown
Contributor

@brian-smith-tcril brian-smith-tcril Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably just remove this completely. We already have a default for buttonText in SearchField.SubmitButton

paragon/src/SearchField/SearchFieldSubmitButton.jsx

Lines 70 to 74 in d2dc235

SearchFieldSubmitButton.defaultProps = {
variant: 'light',
submitButtonLocation: 'internal',
buttonText: 'Search',
};

So it'd be nice to not have this defined in 2 places.

Copy link
Copy Markdown
Contributor Author

@filippovskii09 filippovskii09 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SEARCH_FIELD_BUTTON_TEXT variable has been removed

Copy link
Copy Markdown
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have translations for the "Search" string.
Currently, we have an ongoing forum discussion about incorrect translations, which also concerns the SearchField component button text.

@filippovskii09 could you please wrap this text into translations?

Copy link
Copy Markdown
Contributor Author

@filippovskii09 filippovskii09 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PKulkoRaccoonGang translation was added!


const STYLE_VARIANTS = [
'light',
Expand Down
8 changes: 8 additions & 0 deletions src/SearchField/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,14 @@
.pgn__searchfield__button.btn[type="submit"] {
border-radius: 0;
margin-inline-start: var(--pgn-spacing-search-field-margin-button);

&:focus::before {
border-radius: inherit;
}

&:focus-visible::after {
content: none;
}
}

.pgn__searchfield__iconbutton-submit,
Expand Down