Skip to content

Bug Fix #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankitsingh0913 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bug Fix #411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
334f58b
Bug Fix
ankitsingh0913 Apr 10, 2026
10b0bf9
Fix: handle filename extraction safely using lastIndexOf
ankitsingh0913 Apr 11, 2026
c50e40e
Fix: Handle filename extraction safely using lastIndexOf
ankitsingh0913 Apr 11, 2026
1d1cae1
Fix: Undone the verapdf version range change
ankitsingh0913 Apr 11, 2026
21b78dd
Merge branch 'main' into bugFix
ankitsingh0913 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/DocumentProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ private static void generateOutputs(String inputPdfName, List<List<IObject>> con
imagesDirectory = config.getImageDir();
} else {
String fileName = Paths.get(inputPdfName).getFileName().toString();
String baseName = fileName.substring(0, fileName.length() - 4);
String baseName = fileName.substring(0, fileName.length() - 4).replace(" ", "_");
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
imagesDirectory = config.getOutputFolder() + File.separator + baseName + MarkdownSyntax.IMAGES_DIRECTORY_SUFFIX;
Comment on lines 327 to 331
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Add a regression test for spaced filenames (and multi-dot names).

Please add/update integration coverage to validate default image directory naming for inputs like "my paper.v1.pdf" (expect "my_paper.v1_images"), since current ImageDirIntegrationTest only covers 1901.03003.pdf.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/processors/DocumentProcessor.java`
around lines 327 - 331, Add an integration test in ImageDirIntegrationTest to
cover filenames with spaces and multiple dots (e.g., "my paper.v1.pdf") and
assert that DocumentProcessor constructs imagesDirectory using the sanitized
base name (DocumentProcessor: variable baseName/imagesDirectory) as
"my_paper.v1_images"; update or add tests to instantiate
DocumentProcessor.process (or the relevant method that sets imagesDirectory)
with such inputPdfName and verify the output folder path matches expected
MarkdownSyntax.IMAGES_DIRECTORY_SUFFIX behavior for both spaced and multi-dot
names.

}
StaticLayoutContainers.setImagesDirectory(imagesDirectory);
Expand Down
2 changes: 1 addition & 1 deletion java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<verapdf.version>[1.31.0,1.32.0-RC)</verapdf.version>
<verapdf.version>[1.31.0,1.32.0-RC]</verapdf.version>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
<junit.jupiter.version>5.14.3</junit.jupiter.version>
<assertj.version>3.27.7</assertj.version>
<commons.cli.version>1.11.0</commons.cli.version>
Expand Down