chore: bump openshift-python-wrapper to 11.0.132#1721
Conversation
Signed-off-by: threcc <trecchiu@redhat.com>
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/build-push-pr-image', '/wip', '/hold', '/lgtm', '/verified', '/cherry-pick'} |
📝 WalkthroughWalkthroughThe PR updates the ChangesDependency Version Update
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Line 98: The dependency line adds "openshift-python-wrapper>=11.0.132" which
may pull a release that pins kubernetes<36 and changes bearer-token auth
behavior; validate and fix any pod-log code paths (e.g., functions that
retrieve/stream pod logs) to work with the auth change or constrain
dependencies. Reproduce the issue by running the pod-log retrieval/streaming
code paths and CI tests against an environment using openshift-python-wrapper
11.0.130–11.0.132; if failures occur, either update the pod-log functions to use
the new auth pattern (adjust token handling/headers or client init) or constrain
the dependency set in pyproject.toml (e.g., add a kubernetes version constraint
like "kubernetes<36") and document the compatibility decision. Ensure logs and
tests confirm pod-log functionality after the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e1aec471-e162-468c-897a-d6cdf93f74af
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
|
/cherry-pick 3.5ea1 |
|
/cherry-pick 3.4 |
|
Error cherry-picking. |
|
Error cherry-picking. |
|
Status of building tag latest: success. |
Summary
Bump
openshift-python-wrapperfrom>=11.0.122to>=11.0.132to pick up thekubernetes<36pin added in openshift-python-wrapper#2730.kubernetesPython client v36.0.0+ has a regression (kubernetes-client/python#2596) whereread_namespaced_pod_logreturns therepr()of bytes instead of a decoded string — log output looks likeb'...\n...'with escaped newlines. This causessplitlines()to return a single element andjson.loads()to fail withJSONDecodeError, breaking all 20+ callers ofPod.log()across the test suite.The issue is unfixed in v36.0.0 through v36.0.2.
openshift-python-wrapperv11.0.132 pinskubernetes<36, forcing v35.0.0 which correctly decodes log output.Test plan
Pod.log()returns properly decoded string with real newlinesget_scheduler_decision_logs()correctly parses 12 decision lines from scheduler podtest_singlenode_precise_prefix_cachepasses with this changeSummary by CodeRabbit