Skip to content

Forward impersonation token to BFF modules in federated dev mode #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucferbux wants to merge 1 commit into from
Closed

Forward impersonation token to BFF modules in federated dev mode #7372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/automl/frontend/config/webpack.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,19 @@ module.exports = smp.wrap(
context: ['/api', '/automl/api'],
target: `${PROXY_PROTOCOL}://${PROXY_HOST}:${PROXY_PORT}`,
changeOrigin: true,
headers: getProxyHeaders(),
onProxyReq: (proxyReq, req) => {
const upstreamAuth = req.headers.authorization;
if (upstreamAuth && AUTH_METHOD === 'user_token') {
// Federated mode: forward the upstream token (may be impersonated) as x-forwarded-access-token
const token = upstreamAuth.replace(/^Bearer\s+/i, '');
proxyReq.setHeader('x-forwarded-access-token', token);
} else {
const headers = getProxyHeaders();
Object.entries(headers).forEach(([key, value]) => {
proxyReq.setHeader(key, value);
});
}
},
Comment thread
coderabbitai[bot] marked this conversation as resolved.
},
],
devMiddleware: {
Expand Down
14 changes: 13 additions & 1 deletion packages/autorag/frontend/config/webpack.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,19 @@ module.exports = smp.wrap(
port: PROXY_PORT,
},
changeOrigin: true,
headers: getProxyHeaders(),
onProxyReq: (proxyReq, req) => {
const upstreamAuth = req.headers.authorization;
if (upstreamAuth && AUTH_METHOD === 'user_token') {
// Federated mode: forward the upstream token (may be impersonated) as x-forwarded-access-token
const token = upstreamAuth.replace(/^Bearer\s+/i, '');
proxyReq.setHeader('x-forwarded-access-token', token);
} else {
const headers = getProxyHeaders();
Object.entries(headers).forEach(([key, value]) => {
proxyReq.setHeader(key, value);
});
}
},
Comment thread
coderabbitai[bot] marked this conversation as resolved.
},
],
devMiddleware: {
Expand Down
28 changes: 26 additions & 2 deletions packages/eval-hub/frontend/config/webpack.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,19 @@ module.exports = smp.wrap(
port: PROXY_PORT,
},
changeOrigin: true,
headers: getProxyHeaders(),
onProxyReq: (proxyReq, req) => {
const upstreamAuth = req.headers.authorization;
if (upstreamAuth && AUTH_METHOD === 'user_token') {
// Federated mode: forward the upstream token (may be impersonated) as x-forwarded-access-token
const token = upstreamAuth.replace(/^Bearer\s+/i, '');
proxyReq.setHeader('x-forwarded-access-token', token);
} else {
const headers = getProxyHeaders();
Object.entries(headers).forEach(([key, value]) => {
proxyReq.setHeader(key, value);
});
}
},
},
{
context: ['/mlflow'],
Expand All @@ -103,7 +115,19 @@ module.exports = smp.wrap(
port: MLFLOW_PROXY_PORT,
},
changeOrigin: true,
headers: getProxyHeaders(),
onProxyReq: (proxyReq, req) => {
const upstreamAuth = req.headers.authorization;
if (upstreamAuth && AUTH_METHOD === 'user_token') {
// Federated mode: forward the upstream token (may be impersonated) as x-forwarded-access-token
const token = upstreamAuth.replace(/^Bearer\s+/i, '');
proxyReq.setHeader('x-forwarded-access-token', token);
} else {
const headers = getProxyHeaders();
Object.entries(headers).forEach(([key, value]) => {
proxyReq.setHeader(key, value);
});
}
},
},
],
devMiddleware: {
Expand Down
14 changes: 13 additions & 1 deletion packages/gen-ai/frontend/config/webpack.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,19 @@ module.exports = merge(
protocol: PROXY_PROTOCOL,
},
changeOrigin: true,
headers: getProxyHeaders(),
onProxyReq: (proxyReq, req) => {
const upstreamAuth = req.headers.authorization;
if (upstreamAuth && AUTH_METHOD === 'user_token') {
// Federated mode: forward the upstream token (may be impersonated) as x-forwarded-access-token
const token = upstreamAuth.replace(/^Bearer\s+/i, '');
proxyReq.setHeader('x-forwarded-access-token', token);
} else {
const headers = getProxyHeaders();
Object.entries(headers).forEach(([key, value]) => {
proxyReq.setHeader(key, value);
});
}
},
Comment thread
lucferbux marked this conversation as resolved.
},
],
},
Expand Down
14 changes: 13 additions & 1 deletion packages/maas/frontend/config/webpack.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,19 @@ module.exports = smp.wrap(
port: PROXY_PORT,
},
changeOrigin: true,
headers: getProxyHeaders(),
onProxyReq: (proxyReq, req) => {
const upstreamAuth = req.headers.authorization;
if (upstreamAuth && AUTH_METHOD === 'user_token') {
// Federated mode: forward the upstream token (may be impersonated) as x-forwarded-access-token
const token = upstreamAuth.replace(/^Bearer\s+/i, '');
proxyReq.setHeader('x-forwarded-access-token', token);
} else {
const headers = getProxyHeaders();
Object.entries(headers).forEach(([key, value]) => {
proxyReq.setHeader(key, value);
});
}
},
Comment thread
lucferbux marked this conversation as resolved.
},
],
devMiddleware: {
Expand Down
14 changes: 13 additions & 1 deletion packages/mlflow/frontend/config/webpack.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,19 @@ module.exports = smp.wrap(
},
pathRewrite: { '^/_bff/mlflow/api': '/api' },
changeOrigin: true,
headers: getProxyHeaders(),
onProxyReq: (proxyReq, req) => {
const upstreamAuth = req.headers.authorization;
if (upstreamAuth && AUTH_METHOD === 'user_token') {
// Federated mode: forward the upstream token (may be impersonated) as x-forwarded-access-token
const token = upstreamAuth.replace(/^Bearer\s+/i, '');
proxyReq.setHeader('x-forwarded-access-token', token);
} else {
const headers = getProxyHeaders();
Object.entries(headers).forEach(([key, value]) => {
proxyReq.setHeader(key, value);
});
}
},
Comment thread
lucferbux marked this conversation as resolved.
},
],
devMiddleware: {
Expand Down
Loading