Skip to content

Add Hugging Face organization helper under Allowed organization#7241

Closed
Taj010 wants to merge 1 commit intoopendatahub-io:mainfrom
Taj010:helper-text-org
Closed

Add Hugging Face organization helper under Allowed organization#7241
Taj010 wants to merge 1 commit intoopendatahub-io:mainfrom
Taj010:helper-text-org

Conversation

@Taj010
Copy link
Copy Markdown
Contributor

@Taj010 Taj010 commented Apr 14, 2026

For https://redhat.atlassian.net/browse/RHOAIENG-53778

Description

This PR adds secondary helper text below the Allowed organization field on the Hugging Face catalog source form. This text will inform the administrator that the display name and organization name may differ and provide guidance on locating the correct organization name.

image

How Has This Been Tested?

This has been tested by navigating to /settings/model-resources-operations/model-catalog/add-source and ensuring the helper text is visible under the organization input field.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CredentialsSection.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/constants.tsx is excluded by !**/upstream/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b8add826-2ee2-45aa-bde1-8f2795205eb2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Taj010 Taj010 changed the title add helper text Add Hugging Face organization helper under Allowed organization Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.81%. Comparing base (694ddc2) to head (192cf71).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...lCatalogSettings/components/CredentialsSection.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7241      +/-   ##
==========================================
+ Coverage   64.80%   64.81%   +0.01%     
==========================================
  Files        2441     2441              
  Lines       75996    75996              
  Branches    19158    19158              
==========================================
+ Hits        49247    49260      +13     
+ Misses      26749    26736      -13     
Files with missing lines Coverage Δ
...d/src/app/pages/modelCatalogSettings/constants.tsx 68.18% <ø> (ø)
...lCatalogSettings/components/CredentialsSection.tsx 4.00% <0.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694ddc2...192cf71. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go upstream ?

@Taj010
Copy link
Copy Markdown
Contributor Author

Taj010 commented Apr 15, 2026

Raised an upstream PR - kubeflow/hub#2600 so closing this

@Taj010 Taj010 closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants