gha: set default permissions, and add golangci-lint#106
Draft
thaJeztah wants to merge 5 commits intoopencontainers:masterfrom
Draft
gha: set default permissions, and add golangci-lint#106thaJeztah wants to merge 5 commits intoopencontainers:masterfrom
thaJeztah wants to merge 5 commits intoopencontainers:masterfrom
Conversation
Member
thaJeztah
commented
Jan 16, 2025
thaJeztah
commented
- relates to fix minor linting issues in tests #105
thaJeztah
requested review from
AkihiroSuda,
dmcgowan,
stevvooe and
vbatts
as code owners
Member
Author
|
Good, it works! 😄 |
thaJeztah
force-pushed
the
add_golangci_lint
branch
from
c7ad45a to
f6ec9bd
Compare
Just to please the linters;
verifiers_test.go:28:11: Error return value of `rand.Read` is not checked (errcheck)
rand.Read(p)
^
verifiers_test.go:33:9: Error return value of `io.Copy` is not checked (errcheck)
io.Copy(verifier, bytes.NewReader(p))
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_golangci_lint
branch
from
f6ec9bd to
43391eb
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_golangci_lint
branch
2 times, most recently
from
7d9dedc to
eddaa2b
Compare
Prevent implicit upgrades of Go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_golangci_lint
branch
from
eddaa2b to
d7ab699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.