Skip to content

Specify unit as Mbps for IS-IS reference-bandwidth#1493

Open
earies wants to merge 1 commit into
openconfig:masterfrom
earies:refbw-unit
Open

Specify unit as Mbps for IS-IS reference-bandwidth#1493
earies wants to merge 1 commit into
openconfig:masterfrom
earies:refbw-unit

Conversation

@earies
Copy link
Copy Markdown
Contributor

@earies earies commented May 13, 2026

  • (M) release/models/isis/openconfig-isis-lsp.yang
  • (M) release/models/isis/openconfig-isis-routing.yang
  • (M) release/models/isis/openconfig-isis.yang
    • Add unit to reference-bandwidth
    • Increment to version 1.7.1

Change Scope

Specify unit as Mbps for IS-IS reference-bandwidth. Current definition can lead
to implementation divergence.

Platform Implementations

NOTE: Based off current public model publishes only

Arista:

  • Not supported feature, deviated in OC not supported
  • No native leaf

Refs:

Cisco IOS-XR:

  • OC leafs not supported
  • Native leafs are uint64 but kbps

Refs:

Nokia SROS:

  • OC leafs deviated to scope reduced range of uint32
  • Native leafs are uint64 but bps

Refs:

Nokia SRLinux:

  • OC leafs deviated to scope reduced range of uint32 (assumes Mbps)
  • Native leafs are uint64 but kbps

Refs:

Tree View

No tree updates were made as part of this patchset.

  * (M) release/models/isis/openconfig-isis-lsp.yang
  * (M) release/models/isis/openconfig-isis-routing.yang
  * (M) release/models/isis/openconfig-isis.yang
    - Add unit to reference-bandwidth
    - Increment to version 1.7.1
@earies earies requested a review from a team as a code owner May 13, 2026 13:42
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ISIS YANG models to version 1.7.1, adding a new revision entry and defining the units for the reference-bandwidth leaf. The reviewer suggested changing the units from the abbreviation 'Mbps' to the full lowercase 'megabits per second' to align with OpenConfig style conventions and recommended consolidating the description string for better readability.

Comment thread release/models/isis/openconfig-isis.yang
@sms-juniper
Copy link
Copy Markdown

changes are valid as per Rfc

https://www.rfc-editor.org/rfc/rfc9130.html#name-is-is-yang-module

  leaf reference-bandwidth {
    when "../enabled = 'true'" {
      description
        "Only when auto-cost is enabled.";
    }
    type uint32 {
      range "1..4294967";
    }
    units "Mbits";
    description
      "Configures the reference bandwidth used to automatically
       determine the interface cost (Mbits).  The cost is the
       reference bandwidth divided by the interface speed,
       with 1 being the minimum cost.";
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants