Specify unit as Mbps for IS-IS reference-bandwidth#1493
Open
earies wants to merge 1 commit into
Open
Conversation
* (M) release/models/isis/openconfig-isis-lsp.yang
* (M) release/models/isis/openconfig-isis-routing.yang
* (M) release/models/isis/openconfig-isis.yang
- Add unit to reference-bandwidth
- Increment to version 1.7.1
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ISIS YANG models to version 1.7.1, adding a new revision entry and defining the units for the reference-bandwidth leaf. The reviewer suggested changing the units from the abbreviation 'Mbps' to the full lowercase 'megabits per second' to align with OpenConfig style conventions and recommended consolidating the description string for better readability.
|
changes are valid as per Rfc https://www.rfc-editor.org/rfc/rfc9130.html#name-is-is-yang-module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Scope
Specify unit as Mbps for IS-IS reference-bandwidth. Current definition can lead
to implementation divergence.
Platform Implementations
NOTE: Based off current public model publishes only
Arista:
Refs:
Cisco IOS-XR:
Refs:
Nokia SROS:
Refs:
Nokia SRLinux:
Refs:
Tree View
No tree updates were made as part of this patchset.