Introduce non-AFI-SAFI aggregate prefix limit at global, neighbor, and peer-group levels#1490
Open
mukherso wants to merge 2 commits into
Open
Introduce non-AFI-SAFI aggregate prefix limit at global, neighbor, and peer-group levels#1490mukherso wants to merge 2 commits into
mukherso wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements an aggregate prefix limit across BGP global, neighbor, and peer-group contexts by generalizing existing groupings and introducing a new structural grouping. The review feedback suggests correcting the container description to use "accepted" instead of "received" to align with OpenConfig conventions and recommends adding a state leaf to track when the aggregate limit is exceeded for better operational visibility.
76b9875 to
b781965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files changed:
Change Scope:
This change introduces a non-AFI-SAFI aggregate prefix-limit for accepted routes and prefix-limit-received for received routes at the BGP global, neighbor, and peer-group levels, and renames one internal grouping to reflect its broadened scope.
openconfig-bgp-common-multiprotocol.yang):The original name implied this grouping was scoped exclusively to AFI-SAFI contexts. Since it is now reused outside that context, the name has been shortened accordingly. bgp-common-mp-all-afi-safi-common-prefix-limit-state is unchanged as it remains AFI-SAFI specific. All existing uses statements within the AFI-SAFI prefix-limit containers are updated accordingly. There is no functional change to the existing per-AFI-SAFI prefix-limit behaviour.
openconfig-bgp-common-structure.yang):A new grouping bgp-common-structure-prefix-limit is added, following the existing OpenConfig config/state container pattern. It is applied at the global, neighbor, and peer-group levels via openconfig-bgp-global.yang, openconfig-bgp-neighbor.yang, and openconfig-bgp-peer-group.yang respectively.
This allows operators to set a single aggregate prefix-limit across all address families for a session, complementing the existing per-AFI-SAFI prefix-limit. Note that prefix-limit-exceeded is intentionally not included in the state container at these levels, as exceeded-state tracking is only modelled at the AFI-SAFI granularity.
Relevant pyang tree output:
Platform Implementations
Arista EOS User Guide implements BGP prefix-limit-received using the
neighbor maximum-routes command, which enforces a per-session prefix threshold and may terminate the BGP session upon exceedance.