Clarify enabled/admin-status descriptions for coherent transceiver low-power-mode#1480
Open
earies wants to merge 4 commits into
Open
Clarify enabled/admin-status descriptions for coherent transceiver low-power-mode#1480earies wants to merge 4 commits into
earies wants to merge 4 commits into
Conversation
…w-power-mode
* (M) release/models/interfaces/openconfig-interfaces.yang
- Update `enabled` leaf description to indicate that disabling
an interface SHOULD place a pluggable coherent transceiver
(e.g. ZR/ZR+) into low-power-mode, including channelized
cases where all channels sharing a module must be disabled
- Mirror clarification on `admin-status` leaf and DOWN enum
- Scope behavior to coherent optics; gray (direct-detect) and
non-pluggable interfaces are unaffected
- Increment version to 3.9.0
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-interfaces YANG module to version 3.9.0, clarifying that coherent transceivers should enter low-power-mode when an interface is administratively disabled or in a DOWN state, provided all shared channels are also disabled. A review comment suggests enhancing the admin-status description to explicitly include the multi-channel condition for better consistency with other updated fields.
ahsaanyousaf
approved these changes
May 4, 2026
Contributor
Author
|
@dplore @ElodinLaarz for review/comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enabledleaf description to indicate that disablingan interface SHOULD place a pluggable coherent transceiver
(e.g. ZR/ZR+) into low-power-mode, including channelized
cases where all channels sharing a module must be disabled
admin-statusleaf and DOWN enumnon-pluggable interfaces are unaffected
Change Scope
This PR amends descriptions only. No structural or type changes are made
to the model.
The
enabledconfiguration leaf andadmin-statusoperational state leaf(including the
DOWNenum) are clarified to indicate that, on interfacesbacked by a pluggable coherent transceiver (e.g. ZR/ZR+), administratively
disabling the interface SHOULD additionally place the transceiver into
low-power-mode. When a coherent module is shared by multiple channelized
interfaces, low-power-mode is only entered once all channels sharing the
module have been disabled.
This behavior is explicitly scoped to coherent optics. Gray
(direct-detect) optics and non-pluggable interfaces are not in scope, even
where the underlying module would otherwise support a low-power mode.
While these are description-only changes, behavior is being clarified for
a pre-existing leaf and may require implementations to adjust. The model
is therefore bumped as a minor version
3.8.1->3.9.0. If folks feelotherwise, this could be treated as a patch update - e.g.
3.8.2Platform Implementations
N/A
Tree View
No tree changes - only description updates