Skip to content

Add sent-path-count leaf #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgwilton wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add sent-path-count leaf #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18cae6a
Add sent-path-count leaf
rgwilton Mar 31, 2026
2c17804
Merge branch 'master' into sent-path-count
ElodinLaarz May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions release/models/bgp/openconfig-bgp-common-multiprotocol.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,19 @@ submodule openconfig-bgp-common-multiprotocol {
for multiple protocols in BGP. The groupings are common across
multiple contexts.";

oc-ext:openconfig-version "9.9.1";
oc-ext:openconfig-version "9.10.0";

revision "2026-03-31" {
description
"Add prefix sent path count.";
reference "9.10.0";
}

revision "2025-04-18" {
description
"Clarification to usage of link-bandwidth-ext-community
container under BGP use-multiple-paths`.";
reference "9.9.1";
reference "9.9.1";
}

revision "2025-03-30" {
Expand Down
10 changes: 8 additions & 2 deletions release/models/bgp/openconfig-bgp-common-structure.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,19 @@ submodule openconfig-bgp-common-structure {
"This sub-module contains groupings that are common across multiple BGP
contexts and provide structure around other primitive groupings.";

oc-ext:openconfig-version "9.9.1";
oc-ext:openconfig-version "9.10.0";

revision "2026-03-31" {
description
"Add prefix sent path count.";
reference "9.10.0";
}

revision "2025-04-18" {
description
"Clarification to usage of link-bandwidth-ext-community
container under BGP use-multiple-paths`.";
reference "9.9.1";
reference "9.9.1";
}

revision "2025-03-30" {
Expand Down
10 changes: 8 additions & 2 deletions release/models/bgp/openconfig-bgp-common.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,19 @@ submodule openconfig-bgp-common {
may be application to a subset of global, peer-group or neighbor
contexts.";

oc-ext:openconfig-version "9.9.1";
oc-ext:openconfig-version "9.10.0";

revision "2026-03-31" {
description
"Add prefix sent path count.";
reference "9.10.0";
}

revision "2025-04-18" {
description
"Clarification to usage of link-bandwidth-ext-community
container under BGP use-multiple-paths`.";
reference "9.9.1";
reference "9.9.1";
}

revision "2025-03-30" {
Expand Down
10 changes: 8 additions & 2 deletions release/models/bgp/openconfig-bgp-global.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,19 @@ submodule openconfig-bgp-global {
"This sub-module contains groupings that are specific to the
global context of the OpenConfig BGP module";

oc-ext:openconfig-version "9.9.1";
oc-ext:openconfig-version "9.10.0";

revision "2026-03-31" {
description
"Add prefix sent path count.";
reference "9.10.0";
}

revision "2025-04-18" {
description
"Clarification to usage of link-bandwidth-ext-community
container under BGP use-multiple-paths`.";
reference "9.9.1";
reference "9.9.1";
}

revision "2025-03-30" {
Expand Down
19 changes: 17 additions & 2 deletions release/models/bgp/openconfig-bgp-neighbor.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,19 @@ submodule openconfig-bgp-neighbor {
"This sub-module contains groupings that are specific to the
neighbor context of the OpenConfig BGP module.";

oc-ext:openconfig-version "9.9.1";
oc-ext:openconfig-version "9.10.0";

revision "2026-03-31" {
description
"Add prefix sent path count.";
reference "9.10.0";
}

revision "2025-04-18" {
description
"Clarification to usage of link-bandwidth-ext-community
container under BGP use-multiple-paths`.";
reference "9.9.1";
reference "9.9.1";
}

revision "2025-03-30" {
Expand Down Expand Up @@ -688,6 +694,15 @@ submodule openconfig-bgp-neighbor {
Adj-RIB-Out for the neighbor";
}

leaf sent-path-count {
Copy link
Copy Markdown
Contributor

@rolandphung rolandphung Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too particularly keen on the naming, could you consider sent-add-paths? Mainly dropping count to make it consistent with the other sibling leaves.

type uint32;
description
"The number of add-paths advertised to a neighbor after
the post-policy Adj-RIB-Out. This value reflects the total
number of paths present in the post-policy Adj-RIB-Out for
the neighbor once add-path configuration is applied.";
}
Comment on lines +697 to +704
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The leaf name sent-path-count is inconsistent with the existing total-paths leaf defined in openconfig-bgp-common.yang. Renaming it to sent-paths would improve consistency across the BGP model. Additionally, the description can be refined to refer to 'paths' generally, as the count applies to all advertised paths (including those from the add-paths feature), and should follow the phrasing used in the existing sent leaf for prefixes.

Suggested change
leaf sent-path-count {
type uint32;
description
"The number of add-paths advertised to a neighbor after
the post-policy Adj-RIB-Out. This value reflects the total
number of paths present in the post-policy Adj-RIB-Out for
the neighbor once add-path configuration is applied.";
}
leaf sent-paths {
type uint32;
description
"The number of paths that are advertised to the neighbor after
applying any policies. This count is the number of paths
present in the post-policy Adj-RIB-Out for the neighbor,
including additional paths advertised when add-paths is
enabled.";
}

Copy link
Copy Markdown
Contributor Author

@rgwilton rgwilton Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romeyod, @earies, @jgcumming -please can you let me know if you implement a similar leaf and agree that we should add this into the core OC YANG model (rather than as a Cisco specific augmentation).

Copy link
Copy Markdown
Contributor

@akalluru1 akalluru1 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romeyod is on leave so I'm replying on behalf of him. EOS implements a similar leaf and we agree that it would be good to expose the leaf so that it can be used in the relevant use cases.


leaf installed {
type uint32;
description
Expand Down
10 changes: 8 additions & 2 deletions release/models/bgp/openconfig-bgp-peer-group.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,19 @@ submodule openconfig-bgp-peer-group {
"This sub-module contains groupings that are specific to the
peer-group context of the OpenConfig BGP module.";

oc-ext:openconfig-version "9.9.1";
oc-ext:openconfig-version "9.10.0";

revision "2026-03-31" {
description
"Add prefix sent path count.";
reference "9.10.0";
}

revision "2025-04-18" {
description
"Clarification to usage of link-bandwidth-ext-community
container under BGP use-multiple-paths`.";
reference "9.9.1";
reference "9.9.1";
}

revision "2025-03-30" {
Expand Down
10 changes: 8 additions & 2 deletions release/models/bgp/openconfig-bgp.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,19 @@ module openconfig-bgp {
whereas leaf not present inherits its value from the leaf present
at the next higher level in the hierarchy.";

oc-ext:openconfig-version "9.9.1";
oc-ext:openconfig-version "9.10.0";

revision "2026-03-31" {
description
"Add prefix sent path count.";
reference "9.10.0";
}

revision "2025-04-18" {
description
"Clarification to usage of link-bandwidth-ext-community
container under BGP use-multiple-paths`.";
reference "9.9.1";
reference "9.9.1";
}

revision "2025-03-30" {
Expand Down
Loading