SYS-1.1 Add strata platform support to default_copp_test

feature/system/control_plane_traffic/otg_tests/default_copp_test/default_copp_test.go

@@ -94,6 +94,7 @@ type flowParameters struct {
 type commonEntities struct {
 	dut        *ondatra.DUTDevice
 	ate        *ondatra.ATEDevice
+	platCfg    *platformConfig
 	gnmiClient gpb.GNMIClient
 	ctx        context.Context
 }
@@ -105,6 +106,89 @@ type coppSystemTestcase struct {
 	counters           []string
 }
 
+const (
+	coppCounterPrefix    = "arista-platform-control-plane-traffic-counters:"
+	counterL3LpmOverflow = "l3LpmOverflow"
+	counterL2Unicast     = "l2Unicast"
+	counterIPUnicast     = "ipUnicast"
+	counterL2Broadcast   = "l2Broadcast"
+	counterLACP          = "lacp"
+)
+
+type platformConfig struct {
+	platformName string            // "sand" or "strata"
+	counterNames map[string]string // logical key -> actual counter name
+}
+
+var platformCounterNames = map[string]map[string]string{
+	"sand": {
+		counterL3LpmOverflow: "l3-lpm-overflow",
+		counterL2Unicast:     "l2-unicast",
+		counterIPUnicast:     "ip-unicast",
+		counterL2Broadcast:   "l2-broadcast",
+		counterLACP:          "lacp",
+	},
+	"strata": {
+		counterL3LpmOverflow: "glean",
+		counterL2Unicast:     "switched-tc3-tc5",
+		counterIPUnicast:     "self-ip",
+		counterL2Broadcast:   "other",
+		counterLACP:          "lacp",
+	},
+}
+
+func extractPlatformFromResponse(t *testing.T, resp *gpb.GetResponse) string {
+	t.Helper()
+	notifications := resp.GetNotification()
+	if len(notifications) == 0 || len(notifications[0].GetUpdate()) == 0 {
+		t.Fatal("extractPlatformFromResponse: empty gNMI response")
+	}
+	jsonData := notifications[0].GetUpdate()[0].GetVal().GetJsonIetfVal()
+	var data map[string]interface{}
+	if err := json.Unmarshal(jsonData, &data); err != nil {
+		t.Fatalf("extractPlatformFromResponse: failed to unmarshal JSON: %v", err)
+	}
+	for key := range data {
+		if strings.HasPrefix(key, coppCounterPrefix) {
+			return strings.TrimPrefix(key, coppCounterPrefix)
+		}
+	}
+	t.Fatalf("extractPlatformFromResponse: no platform key with prefix %q found in response", coppCounterPrefix)
+	return ""
+}
+
+func getPlatformConfig(t *testing.T, ctx context.Context, gnmiClient gpb.GNMIClient) *platformConfig {
+	t.Helper()
+	resp, err := gnmiClient.Get(ctx, &gpb.GetRequest{
+		Path: []*gpb.Path{{
+			Elem: []*gpb.PathElem{
+				{Name: "components"},
+				{Name: "component"},
+				{Name: "integrated-circuit"},
+				{Name: "pipeline-counters"},
+				{Name: "control-plane-traffic"},
+				{Name: "vendor"},
+				{Name: "arista"},
+			},
+		}},
+		Type:     gpb.GetRequest_STATE,
+		Encoding: gpb.Encoding_JSON_IETF,
+	})
+	if err != nil {
+		t.Fatalf("getPlatformConfig: gNMI Get failed: %v", err)
+	}
+	platform := extractPlatformFromResponse(t, resp)
+	counters, ok := platformCounterNames[platform]
+	if !ok {
+		t.Fatalf("getPlatformConfig: detected platform %q has no counter mapping", platform)
+	}
+	t.Logf("getPlatformConfig: detected %q platform from OC path", platform)
+	return &platformConfig{
+		platformName: platform,
+		counterNames: counters,
+	}
+}
+
 // configInterfaceDUT configures the interface with the Addrs.
 func (ce *commonEntities) configInterfaceDUT(t *testing.T, i *oc.Interface, a *attrs.Attributes) *oc.Interface {
 	t.Helper()
@@ -335,7 +419,7 @@ func (ce *commonEntities) getDroppedPktCounts(t *testing.T, counters []string) [
 				{Name: "control-plane-traffic"},
 				{Name: "vendor"},
 				{Name: "arista"},
-				{Name: "sand"},
+				{Name: ce.platCfg.platformName},
 				{Name: "state"},
 			},
 		}},
@@ -413,82 +497,89 @@ func TestCoppSystem(t *testing.T) {
 		return
 	}
 
+	platCfg := getPlatformConfig(t, ctx, gnmiClient)
+
 	ce := &commonEntities{
 		dut:        dut,
 		ate:        ate,
+		platCfg:    platCfg,
 		gnmiClient: gnmiClient,
 		ctx:        ctx,
 	}
 
 	ce.configureDUT(t)
+
 	// TODO [https://github.com/openconfig/featureprofiles/issues/4171]: Add test cases for BGP, LDP and LLDP traffic.
 	// Add test case for arista-platform-control-plane-traffic-counters:l3-destination-miss.
 	testCases := []coppSystemTestcase{
 		{
 			name:               "CoppSystemL3LpmOverflowExceedingLimitTest",
 			flowParams:         flowParameters{pps: 20000, packetSize: 512, trafficLayer: 3, trafficType: "l3LpmOverflow"},
 			increasedDropCount: true,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:l3-lpm-overflow"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterL3LpmOverflow]},
 		},
 		{
 			name:               "CoppSystemL3LpmOverflowInLimitTest",
 			flowParams:         flowParameters{pps: 200, packetSize: 512, trafficLayer: 3, trafficType: "l3LpmOverflow"},
 			increasedDropCount: false,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:l3-lpm-overflow"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterL3LpmOverflow]},
 		},
 		{
 			name:               "CoppSystemL2UcastExceedingLimitTest",
 			flowParams:         flowParameters{pps: 600000, packetSize: 512, trafficLayer: 2},
 			increasedDropCount: true,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:l2-unicast"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterL2Unicast]},
 		},
 		{
 			name:               "CoppSystemL2UcastInLimitTest",
 			flowParams:         flowParameters{pps: 600, packetSize: 512, trafficLayer: 2},
 			increasedDropCount: false,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:l2-unicast"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterL2Unicast]},
 		},
 		{
 			name:               "CoppSystemIpUcastExceedingLimitTest",
 			flowParams:         flowParameters{pps: 600000, packetSize: 512, trafficLayer: 3, trafficType: "ipUcast", dstIPAddress: dutSrc.IPv4},
 			increasedDropCount: true,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:ip-unicast"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterIPUnicast]},
 		},
 		{
 			name:               "CoppSystemIpUcastInLimitTest",
 			flowParams:         flowParameters{pps: 600, packetSize: 512, trafficLayer: 3, trafficType: "ipUcast", dstIPAddress: dutSrc.IPv4},
 			increasedDropCount: false,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:ip-unicast"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterIPUnicast]},
 		},
 		{
 			name:               "CoppSystemL2BcastExceedingLimitTest",
 			flowParams:         flowParameters{pps: 600000, packetSize: 512, trafficLayer: 2, trafficType: "l2Bcast", dstMACAddress: broadcastMAC},
 			increasedDropCount: true,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:l2-broadcast"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterL2Broadcast]},
 		},
 		{
 			name:               "CoppSystemL2BcastInLimitTest",
 			flowParams:         flowParameters{pps: 600, packetSize: 512, trafficLayer: 2, trafficType: "l2Bcast", dstMACAddress: broadcastMAC},
 			increasedDropCount: false,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:l2-broadcast"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterL2Broadcast]},
 		},
 		{
 			name:               "CoppSystemLacpExceedingLimitTest",
 			flowParams:         flowParameters{pps: 600000, packetSize: 512, trafficLayer: 2, trafficType: "lacp"},
 			increasedDropCount: true,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:lacp"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterLACP]},
 		},
 		{
 			name:               "CoppSystemLacpInLimitTest",
 			flowParams:         flowParameters{pps: 600, packetSize: 512, trafficLayer: 2, trafficType: "lacp"},
 			increasedDropCount: false,
-			counters:           []string{"arista-platform-control-plane-traffic-counters:lacp"},
+			counters:           []string{coppCounterPrefix + platCfg.counterNames[counterLACP]},
 		},
 	}
 
 	for idx := range testCases {
 		tc := &testCases[idx]
 		t.Run(tc.name, func(t *testing.T) {
+			if strings.HasPrefix(tc.name, "CoppSystemL2Ucast") && deviations.CoppL2UnicastUnsupported(ce.dut) {
+				t.Skip("L2 unicast COPP test not supported on this platform")
+			}
 			ce.testCoppSystemHelper(t, tc)
 		})
 	}

feature/system/control_plane_traffic/otg_tests/default_copp_test/metadata.textproto

@@ -23,8 +23,19 @@ platform_exceptions:  {
 platform_exceptions:  {
   platform:  {
     vendor:  ARISTA
+    hardware_model_regex:  "DCS-728.*|DCS-75.*|DCS-78.*"
   }
   deviations:  {
     interface_enabled:  true
   }
-}
+}
+platform_exceptions:  {
+  platform:  {
+    vendor:  ARISTA
+    hardware_model_regex:  "DCS-7050CX4.*"
+  }
+  deviations:  {
+    interface_enabled:  true
+    copp_l2_unicast_unsupported:  true
+  }
+}

internal/deviations/deviations.go

@@ -2183,3 +2183,9 @@ func PerFlowLoadBalancingUnsupported(dut *ondatra.DUTDevice) bool {
 func BgpMultipathPathsUnderPeerGroupUnsupported(dut *ondatra.DUTDevice) bool {
 	return lookupDUTDeviations(dut).GetBgpMultipathPathsUnderPeerGroupUnsupported()
 }
+
+// CoppL2UnicastUnsupported returns true if the device does not support L2 unicast COPP counter validation.
+// Arista: https://partnerissuetracker.corp.google.com/issues/493487459
+func CoppL2UnicastUnsupported(dut *ondatra.DUTDevice) bool {
+	return lookupDUTDeviations(dut).GetCoppL2UnicastUnsupported()
+}

proto/metadata.proto

@@ -1333,6 +1333,10 @@ message Metadata {
     // Functional translator for Cisco XR vendor drop counters.
     string ciscoxr_vendordrop_ft = 424;
 
+    // Device does not support L2 unicast COPP counter validation.
+    // Arista: https://partnerissuetracker.corp.google.com/issues/493487459
+    bool copp_l2_unicast_unsupported = 425;
+
     // Reserved field numbers and identifiers.
     reserved 84, 9, 28, 20, 38, 43, 90, 97, 55, 89, 19, 36, 35, 40, 113, 131, 141, 173, 234, 254, 231, 300, 241, 49;
   }