gnmi-3 union_replace test

[dplore]

The tests defined here will cover the basic operation of union_replace to
add, remove and change configuration and the scenarios defined in gNMI union_replace section 5.3.
The goal is to catch bugs related to add/remove/change actions and avoid the
complexity of attempting to test all combinations of features and their
configuration items.

In depth configuration scenarios for the full landscape of configuration data
will not be covered in tests of the union_replace feature. Instead, in depth
configuration will be covered within the tests for the given feature. For
example, detailed coverage of BGP configuration with OC and CLI will be covered
in the featureprofiles BGP feature folder.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new test suite for the gNMI union_replace feature, aimed at verifying core configuration management behaviors. By testing the interaction between OpenConfig (OC) and CLI-based configurations, the suite ensures that devices correctly handle configuration updates, omissions, and potential conflicts, while maintaining necessary baseline management settings.

Highlights

• New gNMI union_replace Test Suite: Introduced a comprehensive test suite to validate gNMI union_replace operations, covering configuration addition, removal, modification, and handling of hardware mismatches.
• Baseline Configuration Management: Implemented a mechanism to retrieve and merge the device's baseline CLI configuration with test-specific configurations to ensure management connectivity is maintained during union_replace operations.
• Cross-Vendor Test Coverage: Added metadata and test logic to support various vendors (Arista, Cisco, Juniper, Nokia) with specific deviations and configuration handling for union_replace.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new test suite for the gNMI union_replace operation, including a detailed test plan, vendor-specific metadata, and Go implementations covering idempotent configurations, additions, changes, and hardware mismatch scenarios. The code review identified a critical logic error in the port speed verification test where the assertion logic contradicted the test's intent. Additional feedback addressed a duplicate package import, a mangled URL in the documentation, and improvements to test robustness by using t.Fatalf for terminal setup failures and ensuring the consistent use of defined timeout constants.

[OpenConfigBot]

Pull Request Functional Test Report for #5451 / 2adc9bc

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-3: union_replace	c7ba2258	Log
Cisco 8000E		gNMI-3: union_replace	ef9dc5ef	Log
Cisco XRd		gNMI-3: union_replace	290d058b	Log
Juniper ncPTX		gNMI-3: union_replace	0ecc7c37	Log
Nokia SR Linux		gNMI-3: union_replace	aee00623	Log
Openconfig Lemming		gNMI-3: union_replace	33972474	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-3: union_replace
Cisco 8808		gNMI-3: union_replace
Juniper PTX10008		gNMI-3: union_replace
Nokia 7250 IXR-10e		gNMI-3: union_replace

Help