Add PQC base system test#5442
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a suite of system-level tests designed to ensure that the device under test (DUT) correctly handles and supports Post-Quantum Cryptography (PQC) protocols. By utilizing a custom gRPC dialer with specific TLS curve preferences, the tests verify that secure connections can be established across various management and control plane interfaces. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5442 / 1cd8768Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request adds a new test file to verify Post-Quantum Cryptography (PQC) protocol support for gNMI, gNOI, gNSI, gRIBI, and P4RT services. The reviewer provided several improvement opportunities, including adhering to the repository style guide by implementing TestMain and setupEnvironment, simplifying the logic for handling non-standard gRPC ports, and replacing deprecated gRPC functions. There is also a recommendation to use t.Fatalf for better error handling in the gNSI test.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…update PQC protocol test to use grpc.NewClient.
02bc85e to
8d86dc1
Compare
No description provided.