Skip to content

Add PQC base system test#5442

Open
marcushines wants to merge 15 commits into
mainfrom
hines1
Open

Add PQC base system test#5442
marcushines wants to merge 15 commits into
mainfrom
hines1

Conversation

@marcushines
Copy link
Copy Markdown
Contributor

No description provided.

@marcushines marcushines requested a review from a team as a code owner May 11, 2026 18:09
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a suite of system-level tests designed to ensure that the device under test (DUT) correctly handles and supports Post-Quantum Cryptography (PQC) protocols. By utilizing a custom gRPC dialer with specific TLS curve preferences, the tests verify that secure connections can be established across various management and control plane interfaces.

Highlights

  • New PQC System Tests: Added a new test suite to validate Post-Quantum Cryptography (PQC) support across multiple network protocols including gNMI, gNOI, gNSI, gRIBI, and P4RT.
  • Custom TLS Configuration: Implemented a custom TLS dialer that enables the X25519Kyber768Draft00 key exchange mechanism to verify PQC handshake capabilities on the DUT.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented May 11, 2026

Pull Request Functional Test Report for #5442 / 1cd8768

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
System-1.2: System g protocol test
Cisco 8000E status
System-1.2: System g protocol test
Cisco XRd status
System-1.2: System g protocol test
Juniper ncPTX status
System-1.2: System g protocol test
Nokia SR Linux status
System-1.2: System g protocol test
Openconfig Lemming status
System-1.2: System g protocol test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
System-1.2: System g protocol test
Cisco 8808 status
System-1.2: System g protocol test
Juniper PTX10008 status
System-1.2: System g protocol test
Nokia 7250 IXR-10e status
System-1.2: System g protocol test

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test file to verify Post-Quantum Cryptography (PQC) protocol support for gNMI, gNOI, gNSI, gRIBI, and P4RT services. The reviewer provided several improvement opportunities, including adhering to the repository style guide by implementing TestMain and setupEnvironment, simplifying the logic for handling non-standard gRPC ports, and replacing deprecated gRPC functions. There is also a recommendation to use t.Fatalf for better error handling in the gNSI test.

Copy link
Copy Markdown
Member

@mihirpitale-googler mihirpitale-googler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

marcushines and others added 3 commits May 11, 2026 14:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…update PQC protocol test to use grpc.NewClient.
@marcushines marcushines force-pushed the hines1 branch 2 times, most recently from 02bc85e to 8d86dc1 Compare May 12, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants