Skip to content

FP-1.1: proposal to reduce runtime #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karthikeya-remilla wants to merge 3 commits into
base: main
Choose a base branch
from
+80 −61
Open

FP-1.1: proposal to reduce runtime #5433

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f01866d
proposal to reduce runtime
karthikeya-remilla May 6, 2026
c11e4e2
review comments
karthikeya-remilla May 6, 2026
22e97ed
Merge branch 'main' into fp-1.1-reduce-runtime
karthikeya-remilla May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 67 additions & 61 deletions feature/platform/tests/power_admin_down_up_test/power_admin_down_up_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,60 +25,60 @@ func TestFabricPowerAdmin(t *testing.T) {
dut := ondatra.DUT(t, "dut")
fs := components.FindComponentsByType(t, dut, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_FABRIC)

selected := ""
for _, f := range fs {
t.Run(f, func(t *testing.T) {

empty, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(f).Empty().State()).Val()
if ok && empty {
t.Skipf("Fabric Component %s is empty, hence skipping", f)
}

if !gnmi.Get(t, dut, gnmi.OC().Component(f).Removable().State()) {
t.Skipf("Skip the test on non-removable fabric.")
}

oper := gnmi.Get(t, dut, gnmi.OC().Component(f).OperStatus().State())

if got, want := oper, oc.PlatformTypes_COMPONENT_OPER_STATUS_ACTIVE; got != want {
t.Skipf("Fabric Component %s is already INACTIVE, hence skipping", f)
}

before := helpers.FetchOperStatusUPIntfs(t, dut, false)

powerDownUp(t, dut, f, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_FABRIC, 6*time.Minute)

helpers.ValidateOperStatusUPIntfs(t, dut, before, 12*time.Minute)
})
empty, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(f).Empty().State()).Val()
if ok && empty {
continue
}
if !gnmi.Get(t, dut, gnmi.OC().Component(f).Removable().State()) {
continue
}
oper := gnmi.Get(t, dut, gnmi.OC().Component(f).OperStatus().State())
if got, want := oper, oc.PlatformTypes_COMPONENT_OPER_STATUS_ACTIVE; got != want {
continue
}
Comment thread
karthikeya-remilla marked this conversation as resolved.
Outdated
selected = f
break
}
if selected == "" {
t.Skip("No eligible fabric component found for power-admin-state validation.")
}
t.Run(selected, func(t *testing.T) {
before := helpers.FetchOperStatusUPIntfs(t, dut, false)
powerDownUp(t, dut, selected, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_FABRIC, 6*time.Minute)
helpers.ValidateOperStatusUPIntfs(t, dut, before, 12*time.Minute)
})
}

func TestLinecardPowerAdmin(t *testing.T) {
dut := ondatra.DUT(t, "dut")
ls := components.FindComponentsByType(t, dut, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_LINECARD)

selected := ""
for _, l := range ls {
t.Run(l, func(t *testing.T) {
empty, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(l).Empty().State()).Val()
if ok && empty {
t.Skipf("Linecard Component %s is empty, hence skipping", l)
}
if !gnmi.Get(t, dut, gnmi.OC().Component(l).Removable().State()) {
t.Skipf("Skip the test on non-removable linecard.")
}

oper := gnmi.Get(t, dut, gnmi.OC().Component(l).OperStatus().State())

if got, want := oper, oc.PlatformTypes_COMPONENT_OPER_STATUS_ACTIVE; got != want {
t.Skipf("Linecard Component %s is already INACTIVE, hence skipping", l)
}

before := helpers.FetchOperStatusUPIntfs(t, dut, false)

powerDownUp(t, dut, l, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_LINECARD, 20*time.Minute)

helpers.ValidateOperStatusUPIntfs(t, dut, before, 12*time.Minute)
})
empty, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(l).Empty().State()).Val()
if ok && empty {
continue
}
if !gnmi.Get(t, dut, gnmi.OC().Component(l).Removable().State()) {
continue
}
oper := gnmi.Get(t, dut, gnmi.OC().Component(l).OperStatus().State())
if got, want := oper, oc.PlatformTypes_COMPONENT_OPER_STATUS_ACTIVE; got != want {
continue
}
Comment thread
karthikeya-remilla marked this conversation as resolved.
Outdated
selected = l
break
}
if selected == "" {
t.Skip("No eligible linecard component found for power-admin-state validation.")
}
t.Run(selected, func(t *testing.T) {
before := helpers.FetchOperStatusUPIntfs(t, dut, false)
powerDownUp(t, dut, selected, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_LINECARD, 20*time.Minute)
helpers.ValidateOperStatusUPIntfs(t, dut, before, 12*time.Minute)
})
}

func TestControllerCardPowerAdmin(t *testing.T) {
Expand All @@ -93,26 +93,32 @@ func TestControllerCardPowerAdmin(t *testing.T) {
t.Skipf("Number of controller cards is less than 2. Skipping test for controller-card power-admin-state.")
}

primary := ""
var primary, secondary string
for _, c := range cs {
t.Run(c, func(t *testing.T) {
role := gnmi.Get(t, dut, gnmi.OC().Component(c).RedundantRole().State())
if got, want := role, oc.Platform_ComponentRedundantRole_PRIMARY; got == want {
primary = c
t.Skipf("ControllerCard Component %s is PRIMARY, hence skipping", c)
}

oper := gnmi.Get(t, dut, gnmi.OC().Component(c).OperStatus().State())
if got, want := oper, oc.PlatformTypes_COMPONENT_OPER_STATUS_ACTIVE; got != want {
t.Skipf("ControllerCard Component %s is already INACTIVE, hence skipping", c)
}

powerDownUp(t, dut, c, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_CONTROLLER_CARD, 20*time.Minute)
})
role := gnmi.Get(t, dut, gnmi.OC().Component(c).RedundantRole().State())
switch role {
case oc.Platform_ComponentRedundantRole_PRIMARY:
primary = c
case oc.Platform_ComponentRedundantRole_SECONDARY:
secondary = c
default:
t.Fatalf("Controller card %v has invalid redundant-role, got: %v", c, role.String())
Comment thread
karthikeya-remilla marked this conversation as resolved.
Outdated
}
}
if primary != "" {
gnmi.Await(t, dut, gnmi.OC().Component(primary).SwitchoverReady().State(), 30*time.Minute, true)

if primary == "" || secondary == "" {
t.Skipf("Missing required controller roles: primary=%q secondary=%q", primary, secondary)
}

oper := gnmi.Get(t, dut, gnmi.OC().Component(secondary).OperStatus().State())
if oper != oc.PlatformTypes_COMPONENT_OPER_STATUS_ACTIVE {
t.Skipf("Secondary controller %q not active: got %v", secondary, oper)
}
Comment on lines 105 to +129
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The selection logic for the controller card can be improved for robustness and consistency with the Fabric and Linecard tests. Currently, it uses gnmi.Get for OperStatus after the loop (lines 126-129), which will cause a fatal error if the leaf is missing. Additionally, if multiple secondary controllers exist, the current logic might pick an inactive one and skip the test even if an active one is available. It is better to check for an active secondary during the selection loop using gnmi.Lookup.

	for _, c := range cs {
		role, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(c).RedundantRole().State()).Val()
		if !ok {
			t.Logf("Controller card %q missing redundant-role telemetry; skipping during selection", c)
			continue
		}
		switch role {
		case oc.Platform_ComponentRedundantRole_PRIMARY:
			if primary == "" {
				primary = c
			}
		case oc.Platform_ComponentRedundantRole_SECONDARY:
			if secondary == "" {
				oper, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(c).OperStatus().State()).Val()
				if ok && oper == oc.PlatformTypes_COMPONENT_OPER_STATUS_ACTIVE {
					secondary = c
				} else {
					t.Logf("Controller card %q is SECONDARY but not ACTIVE (got %v); skipping during selection", c, oper)
				}
			}
		default:
			t.Logf("Controller card %q has unexpected redundant-role %v; skipping during selection", c, role)
		}
	}

	if primary == "" || secondary == "" {
		t.Skipf("Missing required active controller roles: primary=%q secondary=%q", primary, secondary)
	}

Copy link
Copy Markdown
Contributor Author

@karthikeya-remilla karthikeya-remilla May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple secondary controllers is an infeasible scenario, so it is not a priority here.

Copy link
Copy Markdown
Contributor Author

@karthikeya-remilla karthikeya-remilla May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple secondary controllers is an infeasible scenario, so it is not a priority here.


t.Run(secondary, func(t *testing.T) {
powerDownUp(t, dut, secondary, oc.PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT_CONTROLLER_CARD, 20*time.Minute)
gnmi.Await(t, dut, gnmi.OC().Component(primary).SwitchoverReady().State(), 30*time.Minute, true)
})
}

func powerDownUp(t *testing.T, dut *ondatra.DUTDevice, name string, cType oc.E_PlatformTypes_OPENCONFIG_HARDWARE_COMPONENT, timeout time.Duration) {
Expand Down
Loading