Adding additional delay between two check request

[Sagrohi]

As per the recent commit to this file, an additional checkreq RPC call has been introduced alongside the existing one. According to the Juniper implementation guidelines, there must be a minimum delay of 120 seconds between two RPC calls; therefore, an extra delay of 120 seconds has been added.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mandatory 120-second delay between consecutive RPC calls within the debug file copying test. This update ensures the test suite remains compliant with Juniper implementation guidelines, preventing potential issues that may arise from rapid successive requests.

Highlights

• Compliance with Juniper Guidelines: Added a 120-second delay between RPC calls to adhere to vendor-specific implementation requirements.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5426 / 9d5247a

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNOI-5.3: Copying Debug Files
Cisco 8000E		gNOI-5.3: Copying Debug Files
Cisco XRd		gNOI-5.3: Copying Debug Files
Juniper ncPTX		gNOI-5.3: Copying Debug Files
Nokia SR Linux		gNOI-5.3: Copying Debug Files
Openconfig Lemming		gNOI-5.3: Copying Debug Files

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNOI-5.3: Copying Debug Files
Cisco 8808		gNOI-5.3: Copying Debug Files
Juniper PTX10008		gNOI-5.3: Copying Debug Files
Nokia 7250 IXR-10e		gNOI-5.3: Copying Debug Files

Help

[gemini-code-assist]

Code Review

This pull request introduces a 120-second delay in the TestCopyingDebugFiles test. The review feedback suggests making this delay conditional for Juniper platforms to avoid unnecessary wait times on other vendors, ensuring more efficient test execution.

[gemini-code-assist]

The 120-second delay is applied globally to all vendors, which unnecessarily increases test execution time for non-Juniper platforms. Since this requirement is specific to Juniper implementation guidelines, the sleep should be gated by a vendor check to maintain efficiency for other platforms.

Note that while time.Sleep is permissible in this repository when waiting for a Device Under Test (DUT) to stabilize after an operation (as opposed to polling for a condition), it should be applied conditionally when the requirement is vendor-specific.

	if dut.Vendor() == ondatra.JUNIPER {
		t.Logf("Waiting 120s between Healthz RPC calls for Juniper...")
		time.Sleep(120 * time.Second)
	}

References

1. time.Sleep is permissible in tests when waiting for a Device Under Test (DUT) to stabilize after an operation, as opposed to polling for a condition.

[Sagrohi]

@googlebot I signed it!