Skip to content

test vrf selection policy #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dracazacula wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −0
Open

test vrf selection policy #5425

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f99cd6
test vrf selection policy
dracazacula May 5, 2026
3a07b14
arista next hop policy
dracazacula May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions feature/gribi/otg_tests/vrf_policy_driven_te/vrf_policy_driven_te_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ func configNonDefaultNetworkInstance(t *testing.T, dut *ondatra.DUTDevice) {
ni.Type = oc.NetworkInstanceTypes_NETWORK_INSTANCE_TYPE_L3VRF
gnmi.Replace(t, dut, gnmi.OC().NetworkInstance(vrf).Config(), ni)
}

}

// configureDUT configures port1-8 on the DUT.
Expand Down Expand Up @@ -2396,6 +2397,12 @@ func TestGribiDecap(t *testing.T) {
configureDUT(t, dut)
})

if res, err := dut.RawAPIs().CLI(t).RunCommand(ctx, "show ver"); err == nil {
t.Logf("Output of 'show ver':\n%s", res.Output())
} else {
t.Logf("Failed to run 'show ver': %v", err)
}

Comment on lines +2401 to +2406
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of vendor-specific CLI commands like show ver should be avoided in feature profile tests to maintain vendor neutrality. Additionally, per the repository style guide, all test logic and logging should be encapsulated within t.Run subtests to ensure the test output clearly reflects the execution steps. If logging the device version is necessary, consider using the vendor-neutral dut.Version() method or querying the appropriate OpenConfig path.

References
  1. Use t.Run for subtests so output clearly reflects passed/failed steps. (link)

t.Run("Apply vrf selectioin policy W to DUT port-1", func(t *testing.T) {
configureVrfSelectionPolicyW(t, dut)
})
Expand Down
Loading