Fixed code as per the regression test failure

[keysightgems]

ReadMe Location: https://github.com/open-traffic-generator/featureprofiles/blob/main/feature/policy_forwarding/otg_tests/mpls_gue_ipv4_decap_scale_test/README.md

Attached pass logs here: https://partnerissuetracker.corp.google.com/u/2/issues/415458482

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses regression test failures by enhancing the reliability and scope of the MPLS-over-GUE decap scale test. The changes focus on improving synchronization between the device under test (DUT) and the traffic generator, ensuring that interfaces and protocols are fully operational before traffic transmission begins. Additionally, the test suite has been updated to include IPv6 static routes and traffic flows, providing more comprehensive validation coverage.

Highlights

• Test Stability Improvements: Introduced robust waiting mechanisms for LAG and subinterface operational states to prevent race conditions during test execution.
• IPv6 Support: Expanded test coverage by adding IPv6 static route configuration and updating traffic flow parameters to support IPv6 validation.
• Protocol Handling: Implemented a retry mechanism for OTG protocol startup to improve reliability in environments with potential convergence delays.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5423 / 9854d28

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test	b1990f9f	Log
Cisco 8000E		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test	9278ef4e	Log
Cisco XRd		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test	9dd1aacd	Log
Juniper ncPTX		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test	74f342cf	Log
Nokia SR Linux		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test	539d4a27	Log
Openconfig Lemming		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test	02edc931	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test
Cisco 8808		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test
Juniper PTX10008		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test
Nokia 7250 IXR-10e		PF-1.20: MPLSoGUE IPV4 decapsulation of IPV4/IPV6 payload scale test

Help

[gemini-code-assist]

Code Review

This pull request enhances the MPLS GUE IPv4 decap scale test by introducing IPv6 static route configuration, refactoring environment setup, and adding robust validation helpers for LAG and subinterface operational states. The changes include new utility functions for OTG protocol convergence and traffic handling. Review feedback highlights a potential issue with side effects when modifying global flow objects in the createflow helper, a logical mismatch between configured packet counts and traffic duration, and an inconsistent IPv6 prefix length on the core interface.

[ksgireesha]

@ram-mac , please review, validate and approve this regression test failure PR #5423

[navaneethyv]

/fptest virtual