Skip to content

build(deps): refresh development tools and FreeBSD action - #1090

Merged
steipete merged 2 commits into
mainfrom
codex/s24-fs-safe-red
Nov 14, 2026
Merged

steipete merged 2 commits into
mainfrom
codex/s24-fs-safe-red

Conversation

@steipete

@steipete steipete commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Refresh development tools to tar 7.5.23 and Vite 8.3.8, and the FreeBSD VM action to 1.6.0. This consolidates #1084 and #1089 on current main, retaining the Node runtime floor, two-day release cooldown, and existing security overrides. No package versions or public APIs change.

CI exposed an existing stress-test deadline mismatch on Windows: the harness aborted after 5 seconds while each lock attempt permits 10 seconds. Allow this one test 15 seconds to settle its lock attempts and verify cleanup. Production deadlines and all ownership/assertion checks remain unchanged.

Validation: independent Codex autoreview through P2 of the complete final diff is scoped-clean; git diff --check passes. Before the test-only deadline fix, full pnpm check passed on Linux (802 test files, 14,915 tests), including build, WASM allocator, compiled documentation, and installed-package checks. The affected stress test passes after the fix. The fresh-machine setup used the documented WASI SDK 34 and pinned .NET SDK 8.0.425. Exact final-head cross-platform CI must pass before merge.

Related: #1084, #1089.

Update tar to 7.5.23, Vite to 8.3.8, and vmactions/freebsd-vm to 1.6.0 while retaining the existing runtime floors and security overrides.
@steipete
steipete requested a review from a team as a code owner November 14, 2026 02:27
@clawsweeper

clawsweeper Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T02:28:42.073124Z e0b93ae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​vite@​8.3.5 ⏵ 8.3.899 +110082 +198100
Updatednpm/​tar@​7.5.22 ⏵ 7.5.23971009992100

View full report

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Nov 14, 2026
@clawsweeper

clawsweeper Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR updates tar, Vite, and the pinned FreeBSD VM action, and gives one lock stress test a 15-second timeout.

Example: A contributor installs the pinned development dependencies.

  • Before: Archive tooling uses tar 7.5.22 and test tooling uses Vite 8.3.5.
  • After: Archive tooling uses tar 7.5.23 and test tooling uses Vite 8.3.8.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) Useful, focused maintenance with substantial final-head CI coverage and no actionable finding.
Proof confidence 🌊 off-meta tidepool Not applicable: Development tooling, CI, and test-only changes require no shipped-entry-point demonstration; existing final-head CI supports validation.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Contributors and CI use older tooling patches, and the lock stress harness can terminate before permitted lock attempts settle.
Reason: The maintainer-authored refresh follows existing tooling maintenance and preserves public behavior and filesystem safety contracts.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: the tooling refresh is absent from current main, and the reviewed diff introduces no actionable defect; platform CI is still finishing.

Priority: P3
Reviewed head: 30bd46cd9bedc4f0b12c699f5feb36319ec56b2e

Before merge

None.

Findings

None.

Agent review details

How this fits together

Development dependencies support archive fixtures, package verification, and test execution, while the FreeBSD workflow builds and qualifies native packages in pinned guests.

flowchart LR
  A[Package manifest] --> B[pnpm dependency graph]
  B --> C[Archive and package tooling]
  B --> D[Vitest and coverage]
  E[FreeBSD workflow] --> F[Pinned VM action]
  F --> G[Native package qualification]
Loading

Technical review

Best possible solution:

Land this focused refresh once the existing final-head CI gates pass.

Do we have a high-confidence way to reproduce the issue?

Source confirms the 10-second lock deadline exceeds the existing default harness timeout; this review did not execute target code or independently reproduce the reported Windows failure.

Is this the best way to solve the issue?

Updating the existing pins and extending only the affected test deadline is a small, complete maintenance change that preserves the safety assertions.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against bcf9a4a4e2c1.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Pinned introduction diff: The complete introduced diff changes development dependency pins, their resolved graph, one action SHA, and one test timeout; production source, exports, runtime requirements, release cooldown, and security overrides remain unchanged. (package.json:211, 30bd46cd9bed)
  • Current main still needs the update: Current main pins tar 7.5.22, Vite 8.3.5, and FreeBSD VM action 1.5.9, so implementation on main is not established. (package.json:211, bcf9a4a4e2c1)
  • Stress-test invariant preserved: The test permits 10-second lock attempts and awaits all 40 contenders before checking mutual exclusion, balanced entry and exit, timeout errors, and cleanup; the patch only extends its harness timeout to 15 seconds. (test/file-lock-concurrency-stress.test.ts:132, 30bd46cd9bed)
  • Existing dependency consumers: Package verification imports tar, coverage merging imports Vite, and the FreeBSD workflow executes the updated action; these are the concrete dependency contracts relevant to review. (scripts/packed-runtime-files.mjs:3, 30bd46cd9bed)
  • Upstream action delta: The selected action retains its input contract and Node 24 entry point; relevant FreeBSD 14.4 configurations update builder 2.2.8 to 2.2.9 and anyvm 0.7.2 to 0.7.7, while the index.js change concerns Rocky Linux ppc64le. (conf/14.4.conf:2, 811efaaac066)
  • Final-head validation: Observed final-head checks show 50 successes, seven running, eight skipped, one cancelled dispatch, and no failures; passing checks include FreeBSD x64, merged coverage, package smoke tests, and Cargo audit. (30bd46cd9bed)

Likely related people:

  • Peter Steinberger: Raw commit a4f8123 adds package.json:202 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: a4f812375819; files: package.json)
  • Josh Avant: Raw commit a37e26c adds .github/workflows/freebsd.yml:84 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: a37e26c8ce4b; files: .github/workflows/freebsd.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Root-cause cluster

Relationship: canonical
Canonical: #1090
Summary: This PR consolidates two narrower dependency updates and adds the stress-test timeout correction.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Labels

Label changes:

  • add P3: Routine development and CI dependency maintenance with a bounded test timeout correction and no established urgent user-facing regression.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine development and CI dependency maintenance with a bounded test timeout correction and no established urgent user-facing regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 13, 2026, 9:55 PM ET / November 14, 2026, 02:55 UTC.

@steipete
steipete merged commit eac3b66 into main Nov 14, 2026
68 of 69 checks passed
@steipete
steipete deleted the codex/s24-fs-safe-red branch November 14, 2026 04:05
@steipete

Copy link
Copy Markdown
Contributor Author

Landed as eac3b66. Final-head CI passed all 57 executed checks: https://github.com/openclaw/fs-safe/actions/runs/43547713484. Independent P2 review was clean. Full Linux pnpm check passed before the test-only timeout adjustment (802 files, 14,915 tests); the affected lock stress test passed afterward. The test harness now permits its existing 10-second operation deadlines to finish without changing lock behavior.

Release verification was dispatched only with dry_run=true: https://github.com/openclaw/fs-safe/actions/runs/43554906785. The pre-existing notarization failure requires the Apple account holder to resolve an expired/missing agreement; no release, tag, signing bypass, or version bump was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant