build: remove outdated arm64 test-skip (fixes #562)#563
Open
CryptoSentinelAI wants to merge 1 commit into
Open
build: remove outdated arm64 test-skip (fixes #562)#563CryptoSentinelAI wants to merge 1 commit into
CryptoSentinelAI wants to merge 1 commit into
Conversation
GitHub Actions now provides native arm64 macOS runners, so cross-compilation and test-skip are no longer necessary. arm64 wheels can be tested directly. Fixes openai#562
|
This is just a reimplementation of my pull request, adding one comment that is unnecessary and makes no sense in the context where the skip test setting has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #562 — removes the outdated
test-skip = "*-macosx_arm64"from cibuildwheel config.Rationale
GitHub Actions now provides native arm64 macOS runners. The original test-skip was added because cross-compiling on Intel made arm64 testing impossible. This is no longer the case.
Change
Verification
macos-latestarm64 runners