Skip to content

Build aarch64 wheels natively #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tongyuantongyu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Build aarch64 wheels natively #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f058df
Build arm wheel natively
tongyuantongyu Jul 21, 2026
f704ac2
Fix clippy & rustfmt error
tongyuantongyu Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ jobs:
target: x86_64
- runner: ubuntu-22.04
target: x86
- runner: ubuntu-22.04
- runner: ubuntu-22.04-arm
target: aarch64
- runner: ubuntu-22.04
- runner: ubuntu-22.04-arm
target: armv7
- runner: ubuntu-22.04
target: ppc64le
Expand All @@ -58,9 +58,6 @@ jobs:
python-version: 3.x
- name: Build wheels
uses: PyO3/maturin-action@db323e2cf5679b7feb8bcb561a36b27a0bc19e79 # v1
env:
# Ensure ring's ARM assembly sees an explicit architecture on aarch64 (glibc)
CFLAGS_aarch64_unknown_linux_gnu: -D__ARM_ARCH=8
with:
target: ${{ matrix.platform.target }}
args: --release --out dist --find-interpreter
Expand All @@ -83,9 +80,9 @@ jobs:
target: x86_64
- runner: ubuntu-22.04
target: x86
- runner: ubuntu-22.04
- runner: ubuntu-22.04-arm
target: aarch64
- runner: ubuntu-22.04
- runner: ubuntu-22.04-arm
target: armv7
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
Expand All @@ -94,9 +91,6 @@ jobs:
python-version: 3.x
- name: Build wheels
uses: PyO3/maturin-action@db323e2cf5679b7feb8bcb561a36b27a0bc19e79 # v1
env:
# Ensure ring's ARM assembly sees an explicit architecture on aarch64 (musl)
CFLAGS_aarch64_unknown_linux_musl: -D__ARM_ARCH=8
with:
target: ${{ matrix.platform.target }}
args: --release --out dist --find-interpreter
Expand Down
7 changes: 1 addition & 6 deletions src/tiktoken.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,7 @@ impl CoreBPE {
let token_is_all_space = |token| {
self.decoder
.get(token)
.map(|token_bytes| {
token_bytes
.iter()
.rev()
.all(|&b| [b' ', b'\n', b'\t'].contains(&b))
})
.map(|token_bytes| token_bytes.iter().rev().all(|&b| b" \n\t".contains(&b)))
.unwrap_or(false)
};
if last_piece_token_len > 0
Expand Down