Add app-server background terminal process APIs by etraut-openai · Pull Request #26041 · openai/codex

etraut-openai · 2026-06-03T04:54:42Z

Summary

Codex Apps needs app-server as the source of truth for chat-started background terminals instead of guessing from local process trees.

This PR adds experimental v2 APIs to list and terminate background terminals for a loaded thread using app-server process ids, so clients can manage background terminals without local PID discovery.

Changes

thread/backgroundTerminals/list returns paginated background terminal records with itemId, app-server processId, command, cwd, nullable osPid, nullable cpuPercent, and nullable rssKb.
thread/backgroundTerminals/terminate terminates one running background terminal by app-server processId and returns whether a process was terminated.
Background terminal list and terminate operations use unified-exec process manager state as their source of truth.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a5856f7ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d37f064d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b90d036c9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0f9c328df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cce9ca7334

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e78df1ea9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b59232841e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai · 2026-06-10T11:50:08Z

+
+        let entry = {
+            let mut store = self.process_store.lock().await;
+            let Some(entry) = store.processes.get(&process_id) else {


Can we verify this is still the same process before removing it?

Yep, good call. Fixed.

jif-oai · 2026-06-10T11:50:36Z

+            let Some(entry) = store.processes.get(&process_id) else {
+                return true;
+            };
+            if !entry.initial_exec_command_returned {


(found by Codex)
This flag can remain false after the initial exec future has been canceled, not just while it is still in flight. A later terminate then succeeds forever while leaving the exited entry, reserved ID, and any approval registration behind. Can we track whether the initial call is actually live, or clean this up from its cancellation/drop path?

jif-oai · 2026-06-10T11:51:19Z

+    limit: Option<u32>,
+) -> Result<(Vec<ThreadBackgroundTerminal>, Option<String>), JSONRPCErrorError> {
+    let start = match cursor {
+        Some(cursor) => terminals


Can we make this cursor survive the anchor process exiting?

Yeah, done.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28b3f1ea58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

feat(app-server): add background terminal process APIs

e4cb80f

etraut-openai marked this pull request as ready for review June 3, 2026 05:05

etraut-openai requested a review from a team as a code owner June 3, 2026 05:05

etraut-openai added 2 commits June 3, 2026 00:39

Simplify background terminal list API

3a5856f

Reduce background terminal test churn

353ed1b

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread codex-rs/app-server-protocol/src/protocol/v2/thread.rs

Restore background terminal metadata fields

0d37f06

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread codex-rs/core/src/unified_exec/process_manager.rs Outdated

Restore background terminal start time

b90d036

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread codex-rs/app-server-protocol/src/protocol/v2/thread.rs Outdated

Comment thread codex-rs/app-server-protocol/schema/typescript/v2/index.ts

Comment thread codex-rs/core/src/unified_exec/process_manager.rs Outdated

etraut-openai added 2 commits June 3, 2026 17:25

codex: address PR review feedback (#26041)

4d1537d

codex: address PR review feedback (#26041)

e0f9c32

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread codex-rs/core/src/unified_exec/process.rs

Comment thread codex-rs/core/src/unified_exec/mod_tests.rs Outdated

etraut-openai added 2 commits June 3, 2026 17:55

codex: address PR review feedback (#26041)

64dc0d2

codex: address PR review feedback (#26041)

cce9ca7

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread codex-rs/core/src/unified_exec/process_manager.rs Outdated

Comment thread codex-rs/app-server-protocol/src/protocol/common.rs

etraut-openai added 3 commits June 3, 2026 18:45

Merge branch 'main' into etraut/background-terminal-apis

33a8e24

codex: stabilize background terminal termination tests

61c5d9c

codex: make background terminal tests deterministic

e78df1e

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread codex-rs/core/src/unified_exec/process_manager.rs Outdated

github-actions Bot mentioned this pull request Jun 4, 2026

📊 AI CLI 工具社区动态日报 2026-06-04 litang9/big_model_radar#11

Open

etraut-openai added 2 commits June 9, 2026 13:59

Merge branch 'main' into etraut/background-terminal-apis

ff2201a

Simplify background terminal APIs

b592328

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread codex-rs/app-server-protocol/src/protocol/v2/thread.rs

Comment thread codex-rs/core/src/unified_exec/mod_tests.rs Outdated

Comment thread codex-rs/app-server-protocol/src/protocol/v2/thread.rs

etraut-openai added 2 commits June 9, 2026 17:01

codex: address background terminal review feedback

b949dc3

codex: simplify background terminal tests

7daf140

github-actions Bot mentioned this pull request Jun 10, 2026

📊 AI CLI 工具社区动态日报 2026-06-10 zx0828/big_model_radar#99

Open

jif-oai approved these changes Jun 10, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jun 10, 2026

📊 AI CLI 工具社区动态日报 2026-06-10 hehongtao88/big_model_radar#6

Open

Address background terminal review comments

dcd1b73

Merge branch 'main' into etraut/background-terminal-apis

28b3f1e

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread codex-rs/core/src/unified_exec/process_manager.rs Outdated

codex: address PR review feedback (#26041)

cac8884

etraut-openai merged commit a1a8807 into main Jun 10, 2026
31 checks passed

etraut-openai deleted the etraut/background-terminal-apis branch June 10, 2026 18:18

github-actions Bot locked and limited conversation to collaborators Jun 10, 2026

Conversation

etraut-openai commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jif-oai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

etraut-openai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

jif-oai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

etraut-openai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

jif-oai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

etraut-openai Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

etraut-openai commented Jun 3, 2026 •

edited

Loading