Archive completed stop-gate review threads - #568
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: daba6afb93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| title: "Codex Stop Gate Review", | ||
| summary: "Stop-gate review of previous Claude turn" | ||
| summary: "Stop-gate review of previous Claude turn", | ||
| jobClass: "stop-review" |
There was a problem hiding this comment.
Avoid classifying user prompts by marker text
When a normal /codex:rescue prompt happens to quote Run a stop-gate review of the previous Claude turn.—for example, while editing or discussing the gate prompt—it is now stored with jobClass: "stop-review". Both findLatestResumableTaskJob and the active-task check only consider jobClass === "task", so --resume-last and task-resume-candidate silently omit that user's rescue thread. Pass an explicit internal stop-review flag from the hook instead of deriving resumability from user-controlled prompt content.
Useful? React with 👍 / 👎.
Summary
ALLOW:orBLOCK:result is durably stored--resume-lastcontinues the latest user rescue taskRoot cause
The stop hook launched reviews as persistent app-server task threads and saved their results, but never called
thread/archive. Successful internal review tasks therefore accumulated in the Codex task list.Validation
npm run buildnpm run check-versionnode --test tests/runtime.test.mjs- 66 passed