Move imports in osc plugins from top level to individual functions to reduce osc load times#3168
Open
dmach wants to merge 1 commit intoopenSUSE:masterfrom
Open
Move imports in osc plugins from top level to individual functions to reduce osc load times#3168dmach wants to merge 1 commit intoopenSUSE:masterfrom
dmach wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
… reduce osc load times
dbb38a6 to
653b55d
Compare
Member
|
This is kinda ugly. can we maybe split the functions that need osc into a separate module that is then only loaded on demand? e.g. just one function-embedded load rather than all of them moved (which still then allows to pyflake check for missing imports imho, which is a nice property to keep). |
Contributor
Author
|
@dirkmueller good point, that sounds like a sane approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.