Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2983 +/- ##
=========================================
Coverage ? 28.87%
=========================================
Files ? 85
Lines ? 14516
Branches ? 0
=========================================
Hits ? 4191
Misses ? 10325
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dirkmueller
reviewed
Jul 4, 2023
| def run(self, prj: str, arch: str): | ||
| Config(self.apiurl, prj) | ||
| cr = CleanupRings(StagingAPI(self.apiurl, prj)) | ||
| cr.whitelist = set(["wine", "wine-nine-standalone", "wine:staging"]) |
Member
There was a problem hiding this comment.
Needed or requiredset perhaps? whitelist is pretty generic ( and non inclusive) terminology . And it's not a list but a set..
Member
Author
There was a problem hiding this comment.
It's actually a list in CleanupRings still, can be changed in a later refactor commit after I got this one working
Member
Author
There was a problem hiding this comment.
It's a dict now with more info, renamed to force_required
dirkmueller
reviewed
Jul 4, 2023
| for providedby in fileinfo.findall('requires_ext/providedby[@name]'): | ||
| name = providedby.get('name') | ||
| # Those are not built as i586 | ||
| if "libgcc" in name or "libstdc++" in name: |
Only used for the old Leap setup. The concept would still work for TW, but baselibs.conf is not enough of an indication (anymore?) whether it needs to be built.
This uses code from cleanup_rings to figure out which packages are needed for a 32bit build and runtime environment for steam and wine.
Vogtinator
force-pushed
the
32bitcleanup
branch
from
552e0b1 to
b1666ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses code from cleanup_rings to figure out which packages are needed
for a 32bit build and runtime environment for steam and wine.
Draft because the API in cleanup_rings had to be changed and that broke cleanup_rings.