opentelemetry-sdk: fix typing issues for metrics instruments#5082
Open
xrmx wants to merge 2 commits intoopen-telemetry:mainfrom
Open
opentelemetry-sdk: fix typing issues for metrics instruments#5082xrmx wants to merge 2 commits intoopen-telemetry:mainfrom
xrmx wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
xrmx
commented
Apr 14, 2026
aabmass
reviewed
Apr 14, 2026
|
|
||
|
|
||
| class _Synchronous: | ||
| class _Instrument: |
Member
There was a problem hiding this comment.
I don't think this makes pyright enforce that _Synchronous properly implements _Instrument, you would want to make this a protocol.
Contributor
Author
There was a problem hiding this comment.
With a protocol the playground example seems to work
11 tasks
tammy-baylis-swi
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This solves 19 issues reported by pyright but not does not make any module clean so list of the excluded files is not updated.
Refs #1608
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: