Lyrical compatibility#520
Open
mxgrey wants to merge 3 commits into
Open
Conversation
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
This was referenced May 6, 2026
Member
luca-della-vedova
left a comment
luca-della-vedova
left a comment
There was a problem hiding this comment.
If we are vendoring websocketpp we should also remove it from the rmf_websocket package.xml to make sure we don't install it anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
rmf_ros2to be compatible with the current state of the ROS Lyrical distro.This PR depends on open-rmf/nlohmann_json_schema_validator_vendor#22
A major change introduced by this PR is to copy a fork of
websocketppdirectly into this repo. While this is a terrible practice, we are in a bind because the upstream source ofwebsocketppis not being maintained. The version ofwebsocketppthat is distributed in Ubuntu 26.04 cannot be compiled with the version of Boost that is distributed in Ubuntu 26.04. There are pull requests that have been opened upstream to fix these problems, but those PRs have gone unreviewed and unmerged.