Skip to content

build: ➖ Remove pkg_resources usage to fix Python 3.12 failure #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pekat-vojtech-kovacik wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

build: ➖ Remove pkg_resources usage to fix Python 3.12 failure #3326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ split_before_expression_after_opening_paren = true
[isort]
line_length = 79
multi_line_output = 0
extra_standard_library = pkg_resources,setuptools,logging,os,warnings,abc
extra_standard_library = setuptools,logging,os,warnings,abc
known_first_party = mmcv
known_third_party = addict,cv2,matplotlib,numpy,onnx,packaging,pytest,pytorch_sphinx_theme,scipy,sphinx,torch,torchvision,yaml,yapf
no_lines_before = STDLIB,LOCALFOLDER
Expand Down
7 changes: 4 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
import os
import platform
import re
from pkg_resources import DistributionNotFound, get_distribution, parse_version
from importlib.metadata import version, PackageNotFoundError
from packaging.version import parse as parse_version
from setuptools import find_packages, setup

EXT_TYPE = ''
Expand Down Expand Up @@ -33,8 +34,8 @@ def choose_requirement(primary, secondary):
return secondary."""
try:
name = re.split(r'[!<>=]', primary)[0]
get_distribution(name)
except DistributionNotFound:
version(name)
except PackageNotFoundError:
return secondary

return str(primary)
Expand Down