Skip to content

Remove dist calculation duplicate #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
novikov-alexander wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Remove dist calculation duplicate #3322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mmcv/ops/csrc/common/box_iou_rotated_utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ HOST_DEVICE_INLINE int convex_hull_graham(const Point<T> (&p)[24],
q[0] = q[t];
q[t] = tmp;

#if defined(__CUDACC__) || defined(__MUSACC__)
// Step 3:
// Sort point 1 ~ num_in according to their relative cross-product values
// (essentially sorting according to angles)
Expand All @@ -191,7 +192,6 @@ HOST_DEVICE_INLINE int convex_hull_graham(const Point<T> (&p)[24],
dist[i] = dot_2d<T>(q[i], q[i]);
}

#if defined(__CUDACC__) || defined(__MUSACC__)
// CUDA version
// In the future, we can potentially use thrust
// for sorting here to improve speed (though not guaranteed)
Expand Down Expand Up @@ -372,6 +372,11 @@ HOST_DEVICE_INLINE T single_box_iou_rotated(T const* const box1_raw,
} else if (mode_flag == 1) {
baseS = area1;
}

if (baseS <= static_cast<T>(1e-14)) {
return static_cast<T>(0);
}

const T iou = intersection / baseS;
return iou;
}
Expand Down