Conversation
|
zhuweichen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
2ec5da3 to
5189ddd
Compare
| order = scores.new_empty(0, dtype=torch.long) | ||
| if dets.device.type == 'npu': | ||
| coefficient = 57.29578 # 180 / PI | ||
| dets_cw = dets_cw.float() |
There was a problem hiding this comment.
dets.float will return a copy of dets. So , is it necessary to copy dets to dets_cw before?
| if dets.device.type == 'npu': | ||
| coefficient = 57.29578 # 180 / PI | ||
| dets_cw = dets_cw.float() | ||
| scores = scores.float() |
There was a problem hiding this comment.
If dets is a float16 tensor, it will be concated with a float32 tensor scores here. Is it expected?
| if torch.cuda.current_device() != points_device: | ||
| torch.cuda.set_device(points_device) | ||
| elif points.device.type == 'npu': | ||
| boxes[:, :, 2] += boxes[:, :, 5] / 2.0 |
There was a problem hiding this comment.
Please leave a comment to describe why we should do this.
c151a35 to
c6478ef
Compare
Update voxelization_npu.cpp Update test_voxelization.py Update voxelization_npu.cpp Update voxelization_npu.cpp Update voxelization_npu.cpp
Add NPU support for dynamic voxelization
repair nms_rotated npu bug
add dtype check for roi_align
Update box_iou_rotated_npu.cpp
Bugfix of NPU adapter of nms3d
Adapt boxes_overlap_bev to box_iou_rotated
fix the bug of DeformableRoiPoolGrad
Interfaces change.
scatter points bug fix
update nms_rotated from openmmlab.mmcv main
roi_align_rotated_v2
add pixel_group_npu
modify internal calls of npu boxes_overlap_bev & box_iou_rotated
git checkout origin pixel_group
…ted" This reverts commit a752d17.
Add npu implementation of assign_score_withk_backward
add diou_npu
Update box_iou_rotated_npu.cpp
Update boxes_overlap_bev C++ adapt file
fix boxes overlap bev bug
remove the roi align rotated v2 ops
|
import importlib import pytest from tests.ut.base import TestBase class TestNPUPlatform(TestBase): |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: