Draft
Conversation
vincentvdwal
requested review from
patrick-zippenfenig and
terraputix
as code owners
Deploying maps with
|
| Latest commit: |
914ae00
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09a269cf.maps-5aj.pages.dev |
| Branch Preview URL: | https://216-look-into-sun-cycle-over.maps-5aj.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR integrates shadow simulation functionality into the map using the mapbox-gl-shadow-simulator library. The feature adds time-based shadow rendering to visualize how shadows change throughout the day based on the selected time.
Changes:
- Added ShadeMap integration with mapbox-gl-shadow-simulator for real-time shadow rendering
- Added new
crepusculepreference to constants (though not yet fully integrated) - Created
shadeMapstore to manage the ShadeMap instance - Synchronized shadow updates with time selector changes
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added mapbox-gl-shadow-simulator and crepuscule dependencies |
| package-lock.json | Updated lock file with new dependency entries |
| src/lib/constants.ts | Added crepuscule preference to defaults; modified indentation formatting |
| src/lib/stores/preferences.ts | Added shadeMap store with ShadeMap type import |
| src/routes/+page.svelte | Initialized ShadeMap on map load with terrain and configuration options |
| src/lib/components/time/time-selector.svelte | Added ShadeMap date synchronization when time changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Maybe this could also be achieved with this package: https://github.com/kikuchan/maplibre-gl-nightlayer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary