Fix boxo dependency and downgrade back to Go 1.20#41
Merged
turbolent merged 2 commits intofeature/stable-cadencefrom May 2, 2024
Merged
Fix boxo dependency and downgrade back to Go 1.20#41turbolent merged 2 commits intofeature/stable-cadencefrom
turbolent merged 2 commits intofeature/stable-cadencefrom
Conversation
turbolent
requested review from
Kay-Zee,
bjartek,
bluesign,
chasefleming,
devbugging,
ianthpun,
janezpodhostnik,
jribbink and
nvdtf
as code owners
jribbink
approved these changes
May 2, 2024
devbugging
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#39 updated to a version of flow-go which incorrectly specified a higher version of boxo than was actually used.
This was fixed in onflow/flow-go#5822.
Roll back to the correct version of boxo, and thus there is no need to require Go 1.20.
As a side effect, this also resolves a problem with Go 1.21 in the Cadence language server, which uses flowkit downstream: onflow/cadence-tools#358 (comment)