Skip to content

Make Greetings generator counter thread-safe #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turbolent merged 1 commit into from
Mar 20, 2026
Merged

Make Greetings generator counter thread-safe #1009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions test/greetings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ package test

import (
"math/rand"
"time"
"sync/atomic"
)

var GreetingScript = []byte(`
transaction(greeting: String) {
execute {
log(greeting.concat(", World!"))
execute {
log(greeting.concat(", World!"))
}
}
`)
Expand Down Expand Up @@ -135,21 +135,19 @@ func init() {
greetingMsgUK,
greetingMsgES,
}

rand.Seed(time.Now().Unix())
}

type Greetings struct {
count int
count atomic.Uint32
}

func GreetingGenerator() *Greetings {
return &Greetings{0}
return &Greetings{}
}

func (g *Greetings) New() string {
defer func() { g.count++ }()
return greetings[g.count%len(greetings)]
count := g.count.Add(1)
return greetings[count%uint32(len(greetings))]
}

func (g *Greetings) Random() string {
Expand Down
Loading