Added optional middleware param to emulator start for metrics#815
Merged
Added optional middleware param to emulator start for metrics#815
Conversation
mfbz
requested review from
bluesign,
chasefleming,
janezpodhostnik,
jribbink and
peterargue
as code owners
jribbink
reviewed
Apr 15, 2025
| func Cmd(getServiceKey serviceKeyFunc) *cobra.Command { | ||
| type HttpMiddleware func(http.Handler) http.Handler | ||
|
|
||
| func Cmd(getServiceKey serviceKeyFunc, httpMiddlewares ...HttpMiddleware) *cobra.Command { |
Contributor
There was a problem hiding this comment.
Personally I would prefer that we switch this to a config struct, i.e.
type Config struct {
GetServiceKey serviceKeyFunc
HTTPMiddlewares []HttpMiddleware
}It is a breaking change, but it shouldn't be a big deal an it keeps things more extensible for the future.
jribbink
reviewed
Apr 15, 2025
Comment on lines
+223
to
+225
| if len(httpMiddlewares) > 0 { | ||
| emu.UseRestMiddleware(httpMiddlewares[0]) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(httpMiddlewares) > 0 { | |
| emu.UseRestMiddleware(httpMiddlewares[0]) | |
| } | |
| for _, middleware := range httpMiddlewares { | |
| emu.UseRestMiddleware(middleware) | |
| } |
jribbink
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #812.
Description
Added an optional http middleware parameter that can be added to rest api server. The goal is being able to use analytics to get some developers metrics as per onflow/flow-cli#1919.