Closed
Conversation
ianthpun
requested review from
bluesign,
chasefleming,
devbugging,
janezpodhostnik,
jribbink and
turbolent
as code owners
turbolent
reviewed
May 16, 2024
Member
turbolent
left a comment
turbolent
left a comment
There was a problem hiding this comment.
Thanks for helping with updating all the dependencies!
Just one issue with the unrelated dependency / Go update
| github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||
| github.com/ipfs/bbloom v0.0.4 // indirect | ||
| github.com/ipfs/boxo v0.17.1-0.20240131173518-89bceff34bf1 // indirect | ||
| github.com/ipfs/boxo v0.19.0 // indirect |
Member
There was a problem hiding this comment.
This shouldn't be updated, the old version is the correct one. See onflow/flow-go#5822. The update to 0.19 is causing the need to update to Go 1.21
turbolent
reviewed
May 16, 2024
| github.com/onflow/flow-core-contracts/lib/go/templates v1.0.0 | ||
| github.com/onflow/flow-go v0.34.0-crescendo-preview.18 | ||
| github.com/onflow/flow-go-sdk v1.0.0-preview.26 | ||
| github.com/onflow/flow-go v0.34.0-crescendo-preview.16 |
Member
There was a problem hiding this comment.
This is downgrading flow-go, but shouldn't
Contributor
Author
|
@turbolent i wonder why its downgrading some things, is it because im giving it the wrong |
Contributor
Author
|
gonna try it again with 4656ff2384409535461abd3e24ad9a2ce128dab7 |
Member
|
Yeah, need at least 4656ff2, i.e. what updated flow-go to that Cadence release (in onflow/flow-go#5930) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automatically update to: