Skip to content

fix: gh icon as relative path #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshmoore merged 1 commit into from
Jul 3, 2026
Merged

fix: gh icon as relative path #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pre_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ def render_authors_md():
# The invertocat icon was downloaded from https://brand.github.com/foundations/logo
# and colored in grey according to the guidelines under the "Color" section.
orcid_icon = "https://orcid.org/assets/vectors/orcid.logo.icon.svg"
github_icon = "icons/invertocat.svg"

for idx, author in enumerate(authors):
name = author['name']
Expand All @@ -187,7 +186,7 @@ def render_authors_md():
name += f" [<img src=\"{orcid_icon}\" alt=\"ORCID iD\" height=12 width=12 style=\"vertical-align: middle;\"/>](https://orcid.org/{author['orcid']})"

if "github" in author:
name += f" [<img src=\"{github_icon}\" alt=\"GitHub\" height=12 width=12 style=\"vertical-align: middle;\"/>](https://github.com/{author['github']})"
name += f" [<img src=icons/invertocat.svg alt=\"GitHub\" height=12 width=12 style=\"vertical-align: middle;\"/>](https://github.com/{author['github']})"

@lubianat lubianat Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this actually fix it? it seems that it does not find this path on the rendered version

Image

maybe using https://github.githubassets.com/favicons/favicon.svg is safer?

on ome/ngff#552 it looks like this to me:

Image

@jo-mueller jo-mueller Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over here this results in
image

@jo-mueller jo-mueller Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is why I went for the slightly altered, but stored in the repo version of the octocat.

will this actually fix it?

I hope so, because the path to the icon was previously written as an absolute path (/path...), which worked in the ngff-spec repo, where root and relative path are the same. Hopefully turning it into a relative path will fix it though! But only one way to find out...



if idx == len(authors) - 1:
Expand Down
Loading