Skip to content

OMBU-793: Combine Google Fonts into a single non-blocking request #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julioalucero wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
+11 −6
Open

OMBU-793: Combine Google Fonts into a single non-blocking request #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<html>
<head>
<title>OmbuLabs Style Guide</title>

<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Lato:wght@700&family=Open+Sans:ital,wght@0,300;0,400;0,700;1,300;1,400;1,700&display=swap">

<link rel="stylesheet" type="text/css" href="static/styleguide.min.css">
<script src="static/styleguide.min.js"></script>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
Expand Down
4 changes: 2 additions & 2 deletions index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
******* application css *****************
****************************************/

// Google Web Fonts
@import url("https://fonts.googleapis.com/css?family=Lato:700|Open+Sans:300,300i,400,400i,700,700i&display=swap");
// Google Web Fonts are loaded by the consuming app via a preconnected,
// non-blocking <link> in the page head (see index.html), not here.

// Font Awesome
$fa-font-path: "@fortawesome/fontawesome-free/webfonts";
Expand Down
2 changes: 1 addition & 1 deletion static/styleguide.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/styleguide.min.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions vendor/assets/stylesheets/ombulabs/styleguide.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
******* application css *******
******************************/

// Google Web Fonts
@import url("https://fonts.googleapis.com/css?family=Lato:700|Open+Sans:300,300i,400,400i,700,700i&display=swap");
// Google Web Fonts are loaded by the consuming app via a preconnected,
// non-blocking <link> in the page head, not here.

// Font Awesome
@import 'font-awesome-sprockets';
Expand Down