Added docker setup for better compatibility#963
Conversation
|
Hey, thanks for creating this PR and figuring out all the details! Seems very useful. A couple of thoughts:
Thanks again, looking forward to merging this. |
| dockerized() { | ||
| pull | ||
| docker compose build | ||
| docker compose run --rm django python manage.py migrate --skip-checks |
There was a problem hiding this comment.
Is skipping checks required, i.e. are they failing in Docker?
There was a problem hiding this comment.
It's not necessary. I was just following the Readme and current code. Will be removed.
There was a problem hiding this comment.
After some checks, yes, it is necessary since the db is empty and django checks for tables that don't exist yet. I'll put it back.
|
I didn't change the current compose-dev.yaml so not to give a surprise to other devs that use a venv with suddenly a 14GB build... Also, it follows the standard (docker compose up). |
|
Seems to be working fine now. Should the README be updated as well? |
— Fixes Python incompatibilities — Compatible with Intel Macs — Added setup function to devsetup.sh — Updated local_settings.py.example to include actual useful values.
— Uses pre-installed uv python image — Uses devsetup.sh functions — Added checks to devsetup.sh for Docker compatibility — Doesn't skip checks at migration — Node 24 & Python 3.13 — Added missing libraries
8eb58d0 to
e123b13
Compare
|
Sorry for the delay! I'm thinking about how we can integrate this with well |
— Easy environment management
— Adds compatibility with Intel Macs
— Added setup function to devsetup.sh —> dockerized()
— Updated local_settings.py.example to include actual useful values. (ports)
I wanted to setup the dev environment and was impossible to do in my machine because of Torch incompatibilities. Now I can set it up reliably. However, building the image takes a long time, but it's the only option for me.