Migrate datacapture library and catalog application#2
Open
LZRS wants to merge 23 commits intoohs-foundation:mainfrom
Open
Migrate datacapture library and catalog application#2LZRS wants to merge 23 commits intoohs-foundation:mainfrom
LZRS wants to merge 23 commits intoohs-foundation:mainfrom
Conversation
Collaborator
Author
|
Desktop Pixel 9 |
jingtang10
reviewed
Apr 23, 2026
jingtang10
left a comment
jingtang10
left a comment
There was a problem hiding this comment.
Thanks @LZRS for this PR. Some high level comments:
- Many hidden folders are included in this PR erroneously, for example
.allstar,.devcontaineretc. Please make sure your git ignore file is set up correclty - Certain github setups are not needed (for now) for this repo, such as issue templates, or. github workflows
- Most of the
buildSrcfolder should probably be ignored for now - The
docsfolder at the moment includes documenation on all Android FHIR SDK libraries. In fact, it might be easier for you to leave out docs at all. We might go through quite a bit of changes on documentation. - Remove Google-mandated documentation such as code of conduct, contributing, etc. Whilst it might be useful for us to include similar documentaiton in the future, we shouldn't be "wholesale" inheriting Google processes. In fact we might be adopting a much lighter touch given the nature of the new organisation, since we have fewer projects and no dedicated teams working on OSS practices, legal, etc.
- Leave out
contribfolder for now - Leave out
kokoro
Overall, this PR can be much simpler, I don't know what's best for you to do, starting afresh or cutting unnecessary bloat in this PR.
Thanks!
Collaborator
Author
Cool, I think I'll just make the changes in this PR |
LZRS
force-pushed
the
catalog-init
branch
2 times, most recently
from
8aeadb7 to
5359195
Compare
jingtang10
reviewed
Apr 24, 2026
Co-authored-by: Jing Tang <jingtang@google.com>
ellykits
changed the title
LZRS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copies over the migration of Catalog application and contrib libraries to KMP, and updates to the new namespace
dev.ohs.fhirIncludes implementation from these PRs
NB: The Kotlin Fhir libraries used still point to the old namespace
com.google.fhir. Will be updated once new releases are made