Master mk 2790#2805
Open
mmanojkmr wants to merge 5 commits intoohs-foundation:masterfrom
Open
Conversation
jingtang10
requested changes
Mar 27, 2025
Contributor
jingtang10
left a comment
jingtang10
left a comment
There was a problem hiding this comment.
can you give the pr a better title?
Comment on lines
+149
to
+151
| if (args.questionnaireTitleKey == "Attachment") { | ||
| showReviewPageBeforeSubmit(true) | ||
| } |
Contributor
There was a problem hiding this comment.
change this back - this is the attachment widget, and we're not trying to show the review page when the user opens the attachment widget.
but we can add the attachment widget to the review page questionnaire, and i think that's reasonable.
Comment on lines
+200
to
+202
| } else if (questionnaireItem.type == Questionnaire.QuestionnaireItemType.ATTACHMENT) { | ||
| return context.getString(R.string.answered) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } else if (questionnaireItem.type == Questionnaire.QuestionnaireItemType.ATTACHMENT) { | |
| return context.getString(R.string.answered) | |
| } | |
| } | |
| if (questionnaireItem.type == Questionnaire.QuestionnaireItemType.ATTACHMENT) { | |
| return context.getString(R.string.answered) | |
| } |
| } | ||
|
|
||
| @Test | ||
| fun `answerString() should return answered with answered`() { |
Contributor
There was a problem hiding this comment.
Suggested change
| fun `answerString() should return answered with answered`() { | |
| fun `answerString() should return answered with answered`() { |
| fun `answerString() should return answered with answered`() { | ||
| val questionnaireViewItem = | ||
| QuestionnaireViewItem( | ||
| Questionnaire.QuestionnaireItemComponent(), |
Contributor
There was a problem hiding this comment.
you need to set the type to attachment
github-project-automation
Bot
moved this from New
to PR under Review
in Android FHIR SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2790
Description
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.