Rendering multiple questions in the same line.

[santosh-pingle]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2788

Description
Implement column count extension.
If column count extension present then apply grid layout manager.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[santosh-pingle]

[santosh-pingle]

@Itskiprotich Can you please test this and share your observations?

[Itskiprotich]

Sure @santosh-pingle. Thanks for the tag.

[Itskiprotich]

@santosh-pingle Thanks for this implementation. I have observed the following:

I have multiple groups, each with a fixed columnCount. When the number of items in a group exceeds this count, they should wrap to the next row. However, this behavior only applies to the first group—subsequent groups do not wrap properly.

• Expected: Every group should respect the columnCount and wrap items correctly.
• Actual: Only the first group wraps, while others do not.

I'm attaching here the sample Questionnaire:

layout_default.json

[santosh-pingle]

Items can be displayed horizontally by grouping them under a group-type item and applying the column count extension.

If the number of child items is a multiple of the column count value, they will be arranged evenly in rows.
If the number of grouped items is not a multiple of the column count value, the remaining space can be used by the next item, provided its span size allows it.

[santosh-pingle]

{
  "resourceType": "Questionnaire",
  "item": [
    {
      "extension": [
        {
          "url": "http://hl7.org/fhir/uv/sdc/StructureDefinition/sdc-questionnaire-columnCount",
          "valuePositiveInt": 2
        }
      ],
      "linkId": "group-column-count-1",
      "type": "group",
      "item": [
        {
          "linkId": "1.1",
          "type": "string",
          "item": [
            {
              "linkId": "1.1.1",
              "text": "Family Name",
              "type": "display",
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "flyover",
                        "display": "Fly-over"
                      }
                    ],
                    "text": "Flyover"
                  }
                }
              ]
            }
          ]
        },
        {
          "linkId": "1.2",
          "type": "string",
          "item": [
            {
              "linkId": "1.2.1",
              "text": "Last Name",
              "type": "display",
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "flyover",
                        "display": "Fly-over"
                      }
                    ],
                    "text": "Flyover"
                  }
                }
              ]
            }
          ]
        }
      ]
    },
    {
      "extension": [
        {
          "url": "http://hl7.org/fhir/uv/sdc/StructureDefinition/sdc-questionnaire-columnCount",
          "valuePositiveInt": 3
        }
      ],
      "linkId": "group-column-count-2",
      "type": "group",
      "item": [
        {
          "linkId": "2.1",
          "type": "string"
        },
        {
          "linkId": "2.2",
          "type": "integer"
        },
        {
          "linkId": "2.3",
          "type": "decimal"
        }
      ]
    }
  ]
}

[santosh-pingle]

{
  "resourceType": "Questionnaire",
  "item": [
    {
      "extension": [
        {
          "url": "http://hl7.org/fhir/uv/sdc/StructureDefinition/sdc-questionnaire-columnCount",
          "valuePositiveInt": 2
        }
      ],
      "linkId": "group-column-count-1",
      "type": "group",
      "item": [
        {
          "linkId": "1.1",
          "type": "string",
          "item": [
            {
              "linkId": "1.1.1",
              "text": "Family Name",
              "type": "display",
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "flyover",
                        "display": "Fly-over"
                      }
                    ],
                    "text": "Flyover"
                  }
                }
              ]
            }
          ]
        },
        {
          "linkId": "1.2",
          "type": "string",
          "item": [
            {
              "linkId": "1.2.1",
              "text": "Last Name",
              "type": "display",
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "flyover",
                        "display": "Fly-over"
                      }
                    ],
                    "text": "Flyover"
                  }
                }
              ]
            }
          ]
        }
      ]
    },
    {
      "extension": [
        {
          "url": "http://hl7.org/fhir/uv/sdc/StructureDefinition/sdc-questionnaire-columnCount",
          "valuePositiveInt": 3
        }
      ],
      "linkId": "group-column-count-2",
      "type": "group",
      "item": [
        {
          "linkId": "2.1",
          "type": "string"
        },
        {
          "linkId": "2.2",
          "type": "integer"
        },
        {
          "linkId": "2.3",
          "type": "decimal"
        }
      ]
    },
    {
      "linkId": "3",
      "type": "decimal"
    },
    {
      "linkId": "4",
      "type": "integer"
    },
    {
      "linkId": "5",
      "type": "string"
    }
  ]
}

[santosh-pingle]

@Itskiprotich

[Itskiprotich]

Thanks @santosh-pingle.

I'll share my observations

[FikriMilano]

Suggested change

	return if (columnCounts.isNotEmpty()) {
	columnCounts.reduce { acc, value -> lcm(acc, value) }
	} else {
	null
	}
	return columnCounts.reduceOrNull { acc, value -> lcm(acc, value) }

try this?