fix(audits): render destroyed-appointment audits when records are gone - #1143
Open
raulriera wants to merge 1 commit into
Open
fix(audits): render destroyed-appointment audits when records are gone#1143raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
audits#show called .fullname on Doctor/Patient lookups without nil checks, so viewing the audit of a destroyed appointment whose doctor or patient was later deleted raised NoMethodError. Fall back to the existing audits.deleted_item_with_id label. Also stop rendering the 'Debug: Data present' line and raw exception message to users when change data cannot be parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audits#showcalled.fullnameon unscopedDoctor/Patientlookups, so the audit page for a destroyed appointment whose doctor or patient was later deleted crashed with NoMethodErroraudits.deleted_item_with_idlabel (already translated in all three locales); the deadbegin/endscaffold around the lookup is removedTest plan