fix(practices): delete the Stripe customer only after the destroy commits - #1142
Open
raulriera wants to merge 1 commit into
Open
fix(practices): delete the Stripe customer only after the destroy commits#1142raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
…mits The before_destroy callback called Stripe inside the destroy transaction, so a rollback left the practice in the database with its Stripe customer (and subscriptions) already deleted. Move it to after_commit on: :destroy; the existing StripeError rescue keeps destroy resilient when the customer is already gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete_stripe_customerran asbefore_destroy, inside the destroy transaction — if the DB destroy rolled back, the practice survived in the database but its Stripe customer (and any subscriptions) had already been deleted externallyafter_commit on: :destroy, so Stripe is only touched once the deletion is durable; the existingStripe::StripeErrorrescue still keeps destroy resilient when the customer is already goneTest plan