fix(appointments): only reset the six-month reminder flag on status changes - #1141
Open
raulriera wants to merge 1 commit into
Open
fix(appointments): only reset the six-month reminder flag on status changes#1141raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
…hanges The after_commit callback fired on every save of a confirmed appointment, so editing notes on an old appointment re-armed the patient's six-month reminder without any new visit, and its blanket rescue silently swallowed real failures. Guard on creation or a status change and let errors surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset_six_month_reminder_flag_if_confirmedran on every create/update commit of a confirmed appointment, so an unrelated edit (e.g. notes) on an old appointment re-armed the patient's six-month reminder cycle without any new visitpreviously_new_record? || saved_change_to_status?(creation still resets, including with the default status)rescue StandardError # no-oparound the patient update is removed — a failed flag reset now surfaces instead of silently skipping a business actionTest plan