fix(controllers): stop rescuing Exception in datebooks#show and reviews#new - #1140
Open
raulriera wants to merge 1 commit into
Open
fix(controllers): stop rescuing Exception in datebooks#show and reviews#new#1140raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
…ws#new rescue Exception swallows everything including signals and timeouts. Narrow datebooks#show to RecordNotFound (its only recoverable failure) and reviews#new to RecordNotFound/ArgumentError/RuntimeError (the Cipher decode failures, matching doctors#appointments). Pins the missing-datebook redirect behavior with a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rescue Exception, which swallows signals, timeouts and every other non-recoverable errordatebooks#shownow rescues onlyActiveRecord::RecordNotFound(its one recoverable failure);reviews#newrescuesRecordNotFound, ArgumentError, RuntimeError— the Cipher decode failure modes, matching the existing pattern indoctors#appointmentsTest plan