fix(auth): show the right message when a signed-in user hits guest pages - #1139
Open
raulriera wants to merge 1 commit into
Open
fix(auth): show the right message when a signed-in user hits guest pages#1139raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
require_no_user flashed t(:not_logged_in) - copy-pasted from require_user - so a signed-in user visiting signup or password reset saw 'Not logged in'. Add an already_signed_in key in en/es/pt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_no_userflashedt(:not_logged_in)— copy-pasted fromrequire_user— so a signed-in user visiting signup or the password-reset page was told "Not logged in"already_signed_inkey in en/es/pt with the correct messageTest plan