fix(doctors): store stable gender values instead of localized labels - #1137
Open
raulriera wants to merge 1 commit into
Open
fix(doctors): store stable gender values instead of localized labels#1137raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
The gender select used the translated, downcased label as the stored value, so the database value depended on the locale active at save time (hombre/mujer, masculino/feminino) - the 'mujer' special-case in Doctor#fullname is existing fallout. Store male/female from a model constant, translate only the label, and translate known values on the show page (legacy values display as stored).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gender === 'mujer'special-case inDoctor#fullnameis existing fallout from thisDoctor::GENDERS(male/female) with translated labels only; the show page translates known values and displays legacy ones as storedTest plan