Skip to content

fix(i18n): quote yes/no keys in the English locale #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raulriera wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(i18n): quote yes/no keys in the English locale #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ en:
gender: Gender
hide_past_appointments: Hide past appointments
home: Home
yes: Yes
no: No
"yes": "Yes"
"no": "No"
help:
patients:
status: Patients without the required profile information are marked as "incomplete".
Expand Down
12 changes: 12 additions & 0 deletions test/unit/locales_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# frozen_string_literal: true

require 'test_helper'

class LocalesTest < ActiveSupport::TestCase
test 'yes and no are translated in every locale' do
%i[en es pt].each do |locale|
assert I18n.exists?(:yes, locale), "missing :yes in #{locale}"
assert I18n.exists?(:no, locale), "missing :no in #{locale}"
end
end
end
Loading