fix(notes): scope noteable lookup to the current practice - #1133
Open
raulriera wants to merge 1 commit into
Open
fix(notes): scope noteable lookup to the current practice#1133raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
find_noteable constantized any *_id param and looked it up unscoped, so a logged-in user could attach or delete notes on another practice's patients (and load arbitrary classes from crafted param names). Notes are only nested under patients in routes, so resolve the patient through the practice scope instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_noteableconstantized any*_idparam and looked records up unscoped, so a logged-in user could create or destroy notes on another practice's patients (and instantiate arbitrary classes from crafted param names)Patient.with_practice(current_user.practice_id).find(params[:patient_id])— cross-practice requests raiseRecordNotFoundTest plan