fix(users): prevent non-admins from updating admin users - #1132
Open
raulriera wants to merge 1 commit into
Open
Conversation
The admin-protection check inside respond_to registered a render but never returned, so execution fell through to @user.update and the non-admin's changes were persisted (update is excluded from require_practice_admin so users can edit themselves). Replace with an early-return guard redirecting to /401.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
users#updateregistered arenderinsiderespond_tobut never returned, so execution fell through and a non-admin's changes to an admin user were persisted (updateis excluded fromrequire_practice_adminso users can edit their own profile)/401before the update runserror:render option the old branch carriedTest plan